Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

torngit github: set up experiment for list_repos page size #232

Merged
merged 1 commit into from
Jun 4, 2024

Conversation

matt-codecov
Copy link
Contributor

@matt-codecov matt-codecov commented May 30, 2024

codecov/engineering-team#1757

github docs on timeouts:

If GitHub takes more than 10 seconds to process an API request, GitHub will terminate the request and you will receive a timeout response and a "Server Error" message.
...
For example, if you are requesting 100 items on a page, you can try requesting fewer items.

list_repos() and family use a page size of 100, and we sometimes observe 502s/504s in response after 10 seconds which is github's cutoff. this PR sets up an experiment to test smaller page sizes

this should be running with a user oauth token that has its own rate limit. so this should probably not cause rate limit issues

Copy link

codecov bot commented May 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.48%. Comparing base (2a8964f) to head (1b2c49a).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #232      +/-   ##
==========================================
- Coverage   89.59%   89.48%   -0.11%     
==========================================
  Files         328      324       -4     
  Lines       10481    10367     -114     
  Branches     1915     1900      -15     
==========================================
- Hits         9390     9277     -113     
+ Misses       1024     1020       -4     
- Partials       67       70       +3     
Flag Coverage Δ
shared-docker-uploader ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@matt-codecov matt-codecov added this pull request to the merge queue Jun 4, 2024
Merged via the queue into main with commit 60c792b Jun 4, 2024
7 of 8 checks passed
@matt-codecov matt-codecov deleted the pr232 branch June 4, 2024 02:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants