Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove proportion and salt params from Feature #142

Merged
merged 2 commits into from
Mar 12, 2024

Conversation

daniel-codecov
Copy link
Contributor

The salt and proportion parameters in Feature are only ever used to create a new feature flag. If a feature flag with the same name already exists in the database, then the parameters are ignored.

This can be confusing as the params don't actually represent the values the feature flag is using 99% of the time. Its more safe to just always create feature flags with the default values (proportion=0, salt=randomlygeneratedstring) and we can modify them via django admin later.

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

@daniel-codecov daniel-codecov force-pushed the daniel/remove-params-from-feature branch from 9a982bb to 27412c2 Compare March 12, 2024 20:53
Copy link

codecov bot commented Mar 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.99%. Comparing base (a98be92) to head (9a982bb).

❗ Current head 9a982bb differs from pull request most recent head 27412c2. Consider uploading reports for the commit 27412c2 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #142      +/-   ##
==========================================
+ Coverage   90.93%   90.99%   +0.05%     
==========================================
  Files         116      115       -1     
  Lines        7083     7048      -35     
  Branches     1630     1623       -7     
==========================================
- Hits         6441     6413      -28     
+ Misses        615      608       -7     
  Partials       27       27              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@daniel-codecov daniel-codecov merged commit a0d0333 into main Mar 12, 2024
8 checks passed
@daniel-codecov daniel-codecov deleted the daniel/remove-params-from-feature branch March 12, 2024 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants