Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: create feature exposures model #141

Merged
merged 8 commits into from
Mar 12, 2024

Conversation

daniel-codecov
Copy link
Contributor

@daniel-codecov daniel-codecov commented Mar 1, 2024

Adds a FeatureExposure model so that we have a way to determine when feature variants are being used by which owners/repos.

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

Copy link

codecov bot commented Mar 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.93%. Comparing base (5cbdf92) to head (31e4818).

❗ Current head 31e4818 differs from pull request most recent head 87e7587. Consider uploading reports for the commit 87e7587 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #141      +/-   ##
==========================================
- Coverage   92.24%   90.93%   -1.31%     
==========================================
  Files         116      116              
  Lines        7089     7083       -6     
  Branches     1630     1630              
==========================================
- Hits         6539     6441      -98     
- Misses        521      615      +94     
+ Partials       29       27       -2     
Flag Coverage Δ
shared-docker-uploader ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@daniel-codecov
Copy link
Contributor Author

looking at this again, I should add some tests before merging

@daniel-codecov daniel-codecov force-pushed the daniel/create-feature-exposures-model branch from fdd51c7 to ceb8fd1 Compare March 12, 2024 20:02
@daniel-codecov daniel-codecov merged commit a98be92 into main Mar 12, 2024
8 checks passed
@daniel-codecov daniel-codecov deleted the daniel/create-feature-exposures-model branch March 12, 2024 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants