Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: don't fetch from db in constructor #138

Merged
merged 2 commits into from
Feb 28, 2024

Conversation

daniel-codecov
Copy link
Contributor

@daniel-codecov daniel-codecov commented Feb 28, 2024

Don't let Feature make requests to database unless check_value() is called. This will help our tests in worker because they don't have access to django db unless we explicitly give it.

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

Copy link

codecov bot commented Feb 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.24%. Comparing base (6dfe609) to head (2cb3da3).

❗ Current head 2cb3da3 differs from pull request most recent head cbe31fa. Consider uploading reports for the commit cbe31fa to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #138      +/-   ##
==========================================
- Coverage   92.24%   92.24%   -0.01%     
==========================================
  Files         115      115              
  Lines        7056     7053       -3     
  Branches     1651     1651              
==========================================
- Hits         6509     6506       -3     
  Misses        519      519              
  Partials       28       28              
Flag Coverage Δ
shared-docker-uploader ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@daniel-codecov daniel-codecov merged commit 5c6de0f into main Feb 28, 2024
8 checks passed
@daniel-codecov daniel-codecov deleted the daniel/small-feature-improvement branch February 28, 2024 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants