Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bundle Analysis: Add Module Report and use dynamic DB sessions some more #132

Merged
merged 3 commits into from
Feb 24, 2024

Conversation

JerrySentry
Copy link
Contributor

@JerrySentry JerrySentry commented Feb 22, 2024

  • Add a shared module report
  • Auto open and close DB sessions for some BundleAnalysisReport class methods

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

@codecov-staging
Copy link

codecov-staging bot commented Feb 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

@codecov-qa
Copy link

codecov-qa bot commented Feb 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.36%. Comparing base (b4d1c6d) to head (202cd13).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #132      +/-   ##
==========================================
+ Coverage   89.34%   89.36%   +0.02%     
==========================================
  Files         104      104              
  Lines        6914     6930      +16     
  Branches     1513     1520       +7     
==========================================
+ Hits         6177     6193      +16     
  Misses        532      532              
  Partials      205      205              
Flag Coverage Δ
python3.10 88.80% <100.00%> (+0.02%) ⬆️
python3.11 88.80% <100.00%> (+0.02%) ⬆️
python3.12 88.80% <100.00%> (+0.02%) ⬆️
python3.8 88.88% <100.00%> (+0.02%) ⬆️
python3.9 89.16% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

codecov bot commented Feb 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.10%. Comparing base (b4d1c6d) to head (202cd13).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #132      +/-   ##
==========================================
+ Coverage   92.08%   92.10%   +0.01%     
==========================================
  Files         111      111              
  Lines        6935     6951      +16     
  Branches     1627     1634       +7     
==========================================
+ Hits         6386     6402      +16     
  Misses        532      532              
  Partials       17       17              
Flag Coverage Δ
python3.10 88.80% <100.00%> (+0.02%) ⬆️
python3.11 88.80% <100.00%> (+0.02%) ⬆️
python3.12 88.80% <100.00%> (+0.02%) ⬆️
python3.8 88.88% <100.00%> (+0.02%) ⬆️
python3.9 89.16% <100.00%> (+0.02%) ⬆️
smart-labels 91.22% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

codecov-public-qa bot commented Feb 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b4d1c6d) 89.34% compared to head (202cd13) 89.36%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #132      +/-   ##
==========================================
+ Coverage   89.34%   89.36%   +0.02%     
==========================================
  Files         104      104              
  Lines        6914     6930      +16     
  Branches     1513     1520       +7     
==========================================
+ Hits         6177     6193      +16     
  Misses        532      532              
  Partials      205      205              
Flag Coverage Δ
python3.10 88.80% <100.00%> (+0.02%) ⬆️
python3.11 88.80% <100.00%> (+0.02%) ⬆️
python3.12 88.80% <100.00%> (+0.02%) ⬆️
python3.8 88.88% <100.00%> (+0.02%) ⬆️
python3.9 89.16% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
shared/bundle_analysis/__init__.py 100.00% <ø> (ø)
shared/bundle_analysis/report.py 100.00% <100.00%> (ø)

Impacted file tree graph

@JerrySentry JerrySentry marked this pull request as ready for review February 23, 2024 00:22
Copy link
Contributor

@ajay-sentry ajay-sentry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@JerrySentry JerrySentry merged commit 4920c9c into main Feb 24, 2024
25 of 26 checks passed
@JerrySentry JerrySentry deleted the ba_2 branch February 24, 2024 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants