ref: Migrate useSunburstCoverage to TSQ V5 #3701
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bundle ReportChanges will increase total bundle size by 683 bytes (0.01%) ⬆️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: gazebo-staging-esmAssets Changed:
Files in
view changes for bundle: gazebo-staging-systemAssets Changed:
Files in
|
Bundle ReportChanges will increase total bundle size by 683 bytes (0.01%) ⬆️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: gazebo-production-systemAssets Changed:
Files in
view changes for bundle: gazebo-production-esmAssets Changed:
Files in
|
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## main #3701 +/- ##
==========================================
- Coverage 98.75% 98.74% -0.02%
==========================================
Files 828 828
Lines 14876 14885 +9
Branches 4222 4232 +10
==========================================
+ Hits 14691 14698 +7
- Misses 176 178 +2
Partials 9 9
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
@@ Coverage Diff @@
## main #3701 +/- ##
==========================================
- Coverage 98.75% 98.74% -0.02%
==========================================
Files 828 828
Lines 14876 14885 +9
Branches 4222 4232 +10
==========================================
+ Hits 14691 14698 +7
- Misses 176 178 +2
Partials 9 9
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAttention: Patch coverage is ✅ All tests successful. No failed tests found.
@@ Coverage Diff @@
## main #3701 +/- ##
==========================================
- Coverage 98.75% 98.74% -0.02%
==========================================
Files 828 828
Lines 14876 14885 +9
Branches 4230 4224 -6
==========================================
+ Hits 14691 14698 +7
- Misses 176 178 +2
Partials 9 9
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
@@ Coverage Diff @@
## main #3701 +/- ##
==========================================
- Coverage 98.75% 98.74% -0.02%
==========================================
Files 828 828
Lines 14876 14885 +9
Branches 4230 4224 -6
==========================================
+ Hits 14691 14698 +7
- Misses 176 178 +2
Partials 9 9
Continue to review full report in Codecov by Sentry.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR migrates
useSunburstCoveragetoSunburstCoverageQueryOpts, as well a couple refactors to bring some old JS up to snuff with TS.Ticket: codecov/engineering-team#3165
Notable Changes
useSunburstCoveragetoSunburstCoverageQueryOptsuseSunburstChartand TS refactor