feat: Update AssetsTable to conditionally render file path column #3565

nicholas-codecov · 2024-12-11T16:05:21Z

Description

Note

Requires (contains code from) #3535 - as it needs to be merged first

This PR adds in a new conditionally rendered column titled "File path" for a given set of supported plugins.

Closes codecov/engineering-team#2958

Notable Changes

Create new empty table for file path supported plugins
Add in x/24 widths to Tailwind config
- Used only for the table as i needed more widths to get things fitting correctly
- Should only be used in break-glass cases
Update AssetsTable with new column
Create/Update tests

Screenshots

File path supported plugin (trust that there are actual values in the column 😅):

Non-file path supported plugin:

codecov-staging · 2024-12-11T16:09:36Z

Bundle Report

Changes will increase total bundle size by 6.03kB (0.03%) ⬆️. This is within the configured threshold ✅

Detailed changes

Bundle name	Size	Change
gazebo-staging-system-esm	5.72MB	3.1kB (0.05%) ⬆️
gazebo-staging-system	5.67MB	2.93kB (0.05%) ⬆️

codecov · 2024-12-11T16:09:51Z

Bundle Report

Changes will increase total bundle size by 6.03kB (0.03%) ⬆️. This is within the configured threshold ✅

Detailed changes

Bundle name	Size	Change
gazebo-production-system	5.67MB	2.93kB (0.05%) ⬆️
gazebo-production-system-esm	5.72MB	3.1kB (0.05%) ⬆️

codecov-notifications · 2024-12-11T16:10:39Z

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

@@           Coverage Diff           @@
##             main    #3565   +/-   ##
=======================================
  Coverage   98.91%   98.91%           
=======================================
  Files         806      806           
  Lines       14478    14498   +20     
  Branches     4105     4112    +7     
=======================================
+ Hits        14321    14341   +20     
  Misses        150      150           
  Partials        7        7

Files with missing lines	Coverage Δ
...ndlesTab/BundleContent/AssetsTable/AssetsTable.tsx	`100.00% <100.00%> (ø)`
...undlesTab/BundleContent/AssetsTable/EmptyTable.tsx	`100.00% <100.00%> (ø)`
...dlesTab/BundleContent/AssetsTable/ModulesTable.tsx	`100.00% <100.00%> (ø)`
src/shared/utils/bundleAnalysis.ts	`100.00% <100.00%> (ø)`

Components	Coverage Δ
Assets	`100.00% <ø> (ø)`
Layouts	`99.71% <ø> (ø)`
Pages	`98.60% <100.00%> (+<0.01%)`	⬆️
Services	`99.36% <ø> (ø)`
Shared	`99.32% <100.00%> (+<0.01%)`	⬆️
UI	`99.14% <ø> (ø)`

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c05416a...bc5ee4b. Read the comment docs.

codecov-qa · 2024-12-11T16:10:40Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.91%. Comparing base (c05416a) to head (bc5ee4b).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

@@           Coverage Diff           @@
##             main    #3565   +/-   ##
=======================================
  Coverage   98.91%   98.91%           
=======================================
  Files         806      806           
  Lines       14478    14498   +20     
  Branches     4112     4112           
=======================================
+ Hits        14321    14341   +20     
  Misses        150      150           
  Partials        7        7

Files with missing lines	Coverage Δ
...ndlesTab/BundleContent/AssetsTable/AssetsTable.tsx	`100.00% <100.00%> (ø)`
...undlesTab/BundleContent/AssetsTable/EmptyTable.tsx	`100.00% <100.00%> (ø)`
...dlesTab/BundleContent/AssetsTable/ModulesTable.tsx	`100.00% <100.00%> (ø)`
src/shared/utils/bundleAnalysis.ts	`100.00% <100.00%> (ø)`

Components	Coverage Δ
Assets	`100.00% <ø> (ø)`
Layouts	`99.71% <ø> (ø)`
Pages	`98.60% <100.00%> (+<0.01%)`	⬆️
Services	`99.36% <ø> (ø)`
Shared	`99.32% <100.00%> (+<0.01%)`	⬆️
UI	`99.14% <ø> (ø)`

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c05416a...bc5ee4b. Read the comment docs.

codecov-public-qa · 2024-12-11T16:10:41Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.91%. Comparing base (c05416a) to head (bc5ee4b).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

@@           Coverage Diff           @@
##             main    #3565   +/-   ##
=======================================
  Coverage   98.91%   98.91%           
=======================================
  Files         806      806           
  Lines       14478    14498   +20     
  Branches     4105     4119   +14     
=======================================
+ Hits        14321    14341   +20     
  Misses        150      150           
  Partials        7        7

Files with missing lines	Coverage Δ
...ndlesTab/BundleContent/AssetsTable/AssetsTable.tsx	`100.00% <100.00%> (ø)`
...undlesTab/BundleContent/AssetsTable/EmptyTable.tsx	`100.00% <100.00%> (ø)`
...dlesTab/BundleContent/AssetsTable/ModulesTable.tsx	`100.00% <100.00%> (ø)`
src/shared/utils/bundleAnalysis.ts	`100.00% <100.00%> (ø)`

Components	Coverage Δ
Assets	`100.00% <ø> (ø)`
Layouts	`99.71% <ø> (ø)`
Pages	`98.60% <100.00%> (+<0.01%)`	⬆️
Services	`99.36% <ø> (ø)`
Shared	`99.32% <100.00%> (+<0.01%)`	⬆️
UI	`99.14% <ø> (ø)`

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c05416a...bc5ee4b. Read the comment docs.

codecov · 2024-12-11T16:10:46Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.91%. Comparing base (c05416a) to head (bc5ee4b).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #3565   +/-   ##
=======================================
  Coverage   98.91%   98.91%           
=======================================
  Files         806      806           
  Lines       14478    14498   +20     
  Branches     4105     4112    +7     
=======================================
+ Hits        14321    14341   +20     
  Misses        150      150           
  Partials        7        7

Files with missing lines	Coverage Δ
...ndlesTab/BundleContent/AssetsTable/AssetsTable.tsx	`100.00% <100.00%> (ø)`
...undlesTab/BundleContent/AssetsTable/EmptyTable.tsx	`100.00% <100.00%> (ø)`
...dlesTab/BundleContent/AssetsTable/ModulesTable.tsx	`100.00% <100.00%> (ø)`
src/shared/utils/bundleAnalysis.ts	`100.00% <100.00%> (ø)`

Components	Coverage Δ
Assets	`100.00% <ø> (ø)`
Layouts	`99.71% <ø> (ø)`
Pages	`98.60% <100.00%> (+<0.01%)`	⬆️
Services	`99.36% <ø> (ø)`
Shared	`99.32% <100.00%> (+<0.01%)`	⬆️
UI	`99.14% <ø> (ø)`

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c05416a...bc5ee4b. Read the comment docs.

codecov-releaser · 2024-12-11T16:11:44Z

✅ Deploy preview for gazebo ready!

Previews expire after 1 month automatically.

Storybook

Commit	Created	Cloud	Enterprise
`38e5544`	Wed, 11 Dec 2024 16:11:44 GMT	Expired	Expired
`957fd88`	Thu, 12 Dec 2024 20:35:05 GMT	Expired	Expired
`bc5ee4b`	Thu, 12 Dec 2024 21:01:01 GMT	Cloud	Enterprise

calvin-codecov · 2024-12-12T20:54:10Z

src/pages/RepoPage/BundlesTab/BundleContent/AssetsTable/AssetsTable.test.tsx

+  useFlags: vi.fn().mockReturnValue({ renderBundleFilePathColumn: true }),
+}))
+
+vi.mock('shared/featureFlags', async (importOriginal) => {


lint error for unused variable

calvin-codecov

1 lint fix. LGTM besides that

nicholas-codecov added 9 commits December 12, 2024 15:26

add in filepath to table before rendering

cdb55ca

add in a list of supported file path plugins

d9c3237

add widths split into 24ths to tailwind config

8299c45

update modules table styles and empty file path column

c15823a

add in new and update old empty table

c98b3ed

update BundleContent tests

6204896

add in new conditional file path column

6305b33

add in feature flag to control the new column

ca63819

fix rebase issue

957fd88

nicholas-codecov force-pushed the gh-eng-2958-update-assets-table-to-conditionally-render-file-path-column branch from 38e5544 to 957fd88 Compare December 12, 2024 20:28

calvin-codecov reviewed Dec 12, 2024

View reviewed changes

calvin-codecov approved these changes Dec 12, 2024

View reviewed changes

one leftover rebase mistake

bc5ee4b

nicholas-codecov added this pull request to the merge queue Dec 13, 2024

Merged via the queue into main with commit d09206c Dec 13, 2024
62 checks passed

nicholas-codecov deleted the gh-eng-2958-update-assets-table-to-conditionally-render-file-path-column branch December 13, 2024 14:37

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: Update AssetsTable to conditionally render file path column #3565

feat: Update AssetsTable to conditionally render file path column #3565

nicholas-codecov commented Dec 11, 2024

codecov-staging bot commented Dec 11, 2024 •

edited

Loading

codecov bot commented Dec 11, 2024 •

edited

Loading

codecov-notifications bot commented Dec 11, 2024 •

edited

Loading

codecov-qa bot commented Dec 11, 2024 •

edited

Loading

codecov-public-qa bot commented Dec 11, 2024 •

edited

Loading

codecov bot commented Dec 11, 2024 •

edited

Loading

codecov-releaser commented Dec 11, 2024 •

edited

Loading

calvin-codecov Dec 12, 2024

calvin-codecov left a comment

feat: Update AssetsTable to conditionally render file path column #3565

feat: Update AssetsTable to conditionally render file path column #3565

Conversation

nicholas-codecov commented Dec 11, 2024

Description

Notable Changes

Screenshots

codecov-staging bot commented Dec 11, 2024 • edited Loading

Bundle Report

codecov bot commented Dec 11, 2024 • edited Loading

Bundle Report

codecov-notifications bot commented Dec 11, 2024 • edited Loading

Codecov Report

codecov-qa bot commented Dec 11, 2024 • edited Loading

Codecov Report

codecov-public-qa bot commented Dec 11, 2024 • edited Loading

Codecov Report

codecov bot commented Dec 11, 2024 • edited Loading

Codecov Report

codecov-releaser commented Dec 11, 2024 • edited Loading

✅ Deploy preview for gazebo ready!

calvin-codecov Dec 12, 2024

Choose a reason for hiding this comment

calvin-codecov left a comment

Choose a reason for hiding this comment

codecov-staging bot commented Dec 11, 2024 •

edited

Loading

codecov bot commented Dec 11, 2024 •

edited

Loading

codecov-notifications bot commented Dec 11, 2024 •

edited

Loading

codecov-qa bot commented Dec 11, 2024 •

edited

Loading

codecov-public-qa bot commented Dec 11, 2024 •

edited

Loading

codecov bot commented Dec 11, 2024 •

edited

Loading

codecov-releaser commented Dec 11, 2024 •

edited

Loading