fix: Do not allow removing sorting from repos table #3554
Conversation
Bundle ReportChanges will decrease total bundle size by 56 bytes (-0.0%) ⬇️. This is within the configured threshold ✅ Detailed changes
|
Bundle ReportChanges will decrease total bundle size by 56 bytes (-0.0%) ⬇️. This is within the configured threshold ✅ Detailed changes
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #3554 +/- ##
==========================================
- Coverage 98.90% 98.90% -0.01%
==========================================
Files 806 806
Lines 14484 14484
Branches 4118 4118
==========================================
- Hits 14326 14325 -1
- Misses 151 152 +1
Partials 7 7
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #3554 +/- ##
==========================================
- Coverage 98.90% 98.90% -0.01%
==========================================
Files 806 806
Lines 14484 14484
Branches 4118 4111 -7
==========================================
- Hits 14326 14325 -1
- Misses 151 152 +1
Partials 7 7
Continue to review full report in Codecov by Sentry.
|
✅ Deploy preview for gazebo ready!Previews expire after 1 month automatically.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #3554 +/- ##
==========================================
- Coverage 98.90% 98.90% -0.01%
==========================================
Files 806 806
Lines 14484 14484
Branches 4111 4111
==========================================
- Hits 14326 14325 -1
- Misses 151 152 +1
Partials 7 7
Continue to review full report in Codecov by Sentry.
|
calvin-codecov
force-pushed
the
cy/analytics_sort_arrow
branch
from
ef3a399 to
238ede5
Compare
calvin-codecov
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #3554 +/- ##
==========================================
- Coverage 98.90% 98.90% -0.01%
==========================================
Files 806 806
Lines 14484 14484
Branches 4118 4111 -7
==========================================
- Hits 14326 14325 -1
- Misses 151 152 +1
Partials 7 7
Continue to review full report in Codecov by Sentry.
|
Description
Closes https://github.com/codecov/internal-issues/issues/1054
Code Example
header.column.getIsSorted()would start out as "desc" and then would switch between "asc" and "false" on clicks that triggered a sorting change. TheenableSortingRemovaltanstack property when set to false doesn't let the column be unsorted as one of the states so now it only cycles between "desc" and "asc"Notable Changes
Screenshots
Screen.Recording.2024-12-06.at.11.47.31.AM.mov
Link to Sample Entry
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.