Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Change flags to anchor style #3519

Merged
merged 4 commits into from
Nov 25, 2024
Merged

Conversation

calvin-codecov
Copy link
Contributor

@calvin-codecov calvin-codecov commented Nov 20, 2024

Description

Just changing links to link: "text-ds-blue-darker" to better represent there are clickable.

Closes codecov/engineering-team#2774

Screenshot 2024-11-20 at 4 24 00 PM

Code Example

Notable Changes

Screenshots

Link to Sample Entry

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

Copy link

codecov bot commented Nov 20, 2024

Bundle Report

Changes will decrease total bundle size by 6.14MB (-35.43%) ⬇️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
gazebo-production-system 5.57MB 68 bytes (-0.0%) ⬇️
gazebo-production-system-esm 5.62MB 276 bytes (-0.0%) ⬇️
gazebo-production-array-push (removed) 6.14MB (-100.0%) ⬇️

@codecov-staging
Copy link

codecov-staging bot commented Nov 20, 2024

Bundle Report

Changes will decrease total bundle size by 6.14MB (-35.43%) ⬇️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
gazebo-staging-system 5.57MB 68 bytes (-0.0%) ⬇️
gazebo-staging-system-esm 5.62MB 276 bytes (-0.0%) ⬇️
gazebo-staging-array-push (removed) 6.14MB (-100.0%) ⬇️

@codecov-staging
Copy link

codecov-staging bot commented Nov 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3519   +/-   ##
=======================================
  Coverage   98.93%   98.93%           
=======================================
  Files         808      808           
  Lines       14414    14414           
  Branches     4099     4099           
=======================================
  Hits        14260    14260           
  Misses        147      147           
  Partials        7        7           
Files with missing lines Coverage Δ
...ageTab/FlagsTab/subroute/FlagsTable/FlagsTable.tsx 100.00% <ø> (ø)
Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 100.00% <ø> (ø)
Pages 98.59% <ø> (ø)
Services 99.36% <ø> (ø)
Shared 99.33% <ø> (ø)
UI 99.21% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cfffad4...1a6f13b. Read the comment docs.

Copy link

codecov-public-qa bot commented Nov 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.93%. Comparing base (cfffad4) to head (1a6f13b).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3519   +/-   ##
=======================================
  Coverage   98.93%   98.93%           
=======================================
  Files         808      808           
  Lines       14414    14414           
  Branches     4099     4106    +7     
=======================================
  Hits        14260    14260           
  Misses        147      147           
  Partials        7        7           
Files with missing lines Coverage Δ
...ageTab/FlagsTab/subroute/FlagsTable/FlagsTable.tsx 100.00% <ø> (ø)
Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 100.00% <ø> (ø)
Pages 98.59% <ø> (ø)
Services 99.36% <ø> (ø)
Shared 99.33% <ø> (ø)
UI 99.21% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cfffad4...1a6f13b. Read the comment docs.

@codecov-qa
Copy link

codecov-qa bot commented Nov 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.93%. Comparing base (cfffad4) to head (1a6f13b).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3519   +/-   ##
=======================================
  Coverage   98.93%   98.93%           
=======================================
  Files         808      808           
  Lines       14414    14414           
  Branches     4099     4106    +7     
=======================================
  Hits        14260    14260           
  Misses        147      147           
  Partials        7        7           
Files with missing lines Coverage Δ
...ageTab/FlagsTab/subroute/FlagsTable/FlagsTable.tsx 100.00% <ø> (ø)
Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 100.00% <ø> (ø)
Pages 98.59% <ø> (ø)
Services 99.36% <ø> (ø)
Shared 99.33% <ø> (ø)
UI 99.21% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cfffad4...1a6f13b. Read the comment docs.

Copy link

codecov bot commented Nov 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.93%. Comparing base (cfffad4) to head (1a6f13b).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3519   +/-   ##
=======================================
  Coverage   98.93%   98.93%           
=======================================
  Files         808      808           
  Lines       14414    14414           
  Branches     4106     4099    -7     
=======================================
  Hits        14260    14260           
  Misses        147      147           
  Partials        7        7           
Files with missing lines Coverage Δ
...ageTab/FlagsTab/subroute/FlagsTable/FlagsTable.tsx 100.00% <ø> (ø)
Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 100.00% <ø> (ø)
Pages 98.59% <ø> (ø)
Services 99.36% <ø> (ø)
Shared 99.33% <ø> (ø)
UI 99.21% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cfffad4...1a6f13b. Read the comment docs.

@codecov-releaser
Copy link
Contributor

codecov-releaser commented Nov 20, 2024

✅ Deploy preview for gazebo ready!

Previews expire after 1 month automatically.

Storybook

Commit Created Cloud Enterprise
63426da Wed, 20 Nov 2024 19:38:24 GMT Expired Expired
933ebec Thu, 21 Nov 2024 00:30:23 GMT Expired Expired
933ebec Thu, 21 Nov 2024 00:31:11 GMT Expired Expired
1a6f13b Mon, 25 Nov 2024 20:27:15 GMT Cloud Enterprise

@calvin-codecov calvin-codecov added this pull request to the merge queue Nov 25, 2024
Merged via the queue into main with commit 2a65caa Nov 25, 2024
61 of 62 checks passed
@calvin-codecov calvin-codecov deleted the cy/flags_anchor_styling branch November 25, 2024 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Flags need anchoring treatment/styling
3 participants