-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Upgrade http-proxy-middleware to ^2.0.7 #3488
Conversation
Bundle ReportBundle size has no change ✅ |
Bundle ReportChanges will increase total bundle size by 168 bytes (0.0%) ⬆️. This is within the configured threshold ✅ Detailed changes
ℹ️ *Bundle size includes cached data from a previous commit |
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #3488 +/- ##
===========================================
+ Coverage 74.84% 99.09% +24.25%
===========================================
Files 808 808
Lines 14402 14402
Branches 4100 4100
===========================================
+ Hits 10779 14272 +3493
+ Misses 3188 123 -3065
+ Partials 435 7 -428 see 194 files with indirect coverage changes
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #3488 +/- ##
=======================================
Coverage 99.09% 99.09%
=======================================
Files 808 808
Lines 14402 14402
Branches 4100 4100
=======================================
Hits 14272 14272
Misses 123 123
Partials 7 7
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #3488 +/- ##
=======================================
Coverage 99.09% 99.09%
=======================================
Files 808 808
Lines 14402 14402
Branches 4100 4100
=======================================
Hits 14272 14272
Misses 123 123
Partials 7 7
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #3488 +/- ##
=======================================
Coverage 99.09% 99.09%
=======================================
Files 808 808
Lines 14402 14402
Branches 4093 4100 +7
=======================================
Hits 14272 14272
Misses 123 123
Partials 7 7
Continue to review full report in Codecov by Sentry.
|
✅ Deploy preview for gazebo ready!Previews expire after 1 month automatically.
|
package.json
Outdated
@@ -176,7 +176,8 @@ | |||
"micromatch": "^4.0.8", | |||
"express": "^4.21.0", | |||
"path-to-regexp@^1.7.0": "^1.9.0", | |||
"path-to-regexp@^6.2.0": "^6.3.0" | |||
"path-to-regexp@^6.2.0": "^6.3.0", | |||
"http-proxy-middleware": "^2.0.7" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we still need this if we're also updating it above?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ahh sorry, I should have clarified in the PR comment that we also use the pckage. The update above was for our own use but we need the resolution for react-scripts since we can't upgrade that.
a53aa9d
to
aa39119
Compare
Description
Closes https://github.com/codecov/internal-issues/issues/971
Upgraded our own use of the package for
├─ gazebo@workspace:.
│ └─ http-proxy-middleware@npm:2.0.6 [6563e] (via npm:^2.0.6 [6563e])
but adding a resolution as it is also referenced here
gazebo@workspace:.
└─ react-scripts@npm:5.0.1 [6563e] (via npm:^5.0.1 [6563e])
└─ webpack-dev-server@npm:4.15.2 [37b33] (via npm:^4.6.0 [37b33])
└─ http-proxy-middleware@npm:2.0.6 [edb85] (via npm:^2.0.3 [edb85])
We can remove this resolution when we pull out react-scripts as part of Gazebo V2 work tickets.