Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Upgrade http-proxy-middleware to ^2.0.7 #3488

Merged
merged 3 commits into from
Nov 12, 2024
Merged

Conversation

calvin-codecov
Copy link
Contributor

@calvin-codecov calvin-codecov commented Nov 12, 2024

Description

Closes https://github.com/codecov/internal-issues/issues/971

Upgraded our own use of the package for
├─ gazebo@workspace:.
│ └─ http-proxy-middleware@npm:2.0.6 [6563e] (via npm:^2.0.6 [6563e])

but adding a resolution as it is also referenced here
gazebo@workspace:.
└─ react-scripts@npm:5.0.1 [6563e] (via npm:^5.0.1 [6563e])
└─ webpack-dev-server@npm:4.15.2 [37b33] (via npm:^4.6.0 [37b33])
└─ http-proxy-middleware@npm:2.0.6 [edb85] (via npm:^2.0.3 [edb85])

We can remove this resolution when we pull out react-scripts as part of Gazebo V2 work tickets.

Copy link

codecov bot commented Nov 12, 2024

Bundle Report

Bundle size has no change ✅

@codecov-staging
Copy link

codecov-staging bot commented Nov 12, 2024

Bundle Report

Changes will increase total bundle size by 168 bytes (0.0%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
gazebo-staging-system-esm* 5.61MB 168 bytes (0.0%) ⬆️

ℹ️ *Bundle size includes cached data from a previous commit

Copy link

codecov bot commented Nov 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.09%. Comparing base (082770a) to head (df9e14e).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #3488       +/-   ##
===========================================
+ Coverage   74.84%   99.09%   +24.25%     
===========================================
  Files         808      808               
  Lines       14402    14402               
  Branches     4100     4100               
===========================================
+ Hits        10779    14272     +3493     
+ Misses       3188      123     -3065     
+ Partials      435        7      -428     

see 194 files with indirect coverage changes

Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 100.00% <ø> (ø)
Pages 98.81% <ø> (+43.15%) ⬆️
Services 99.36% <ø> (+0.50%) ⬆️
Shared 99.74% <ø> (+1.02%) ⬆️
UI 99.21% <ø> (+0.35%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 082770a...df9e14e. Read the comment docs.

@codecov-qa
Copy link

codecov-qa bot commented Nov 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.09%. Comparing base (082770a) to head (df9e14e).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3488   +/-   ##
=======================================
  Coverage   99.09%   99.09%           
=======================================
  Files         808      808           
  Lines       14402    14402           
  Branches     4100     4100           
=======================================
  Hits        14272    14272           
  Misses        123      123           
  Partials        7        7           
Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 100.00% <ø> (ø)
Pages 98.81% <ø> (ø)
Services 99.36% <ø> (ø)
Shared 99.74% <ø> (ø)
UI 99.21% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 082770a...df9e14e. Read the comment docs.

Copy link

codecov-public-qa bot commented Nov 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.09%. Comparing base (082770a) to head (df9e14e).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3488   +/-   ##
=======================================
  Coverage   99.09%   99.09%           
=======================================
  Files         808      808           
  Lines       14402    14402           
  Branches     4100     4100           
=======================================
  Hits        14272    14272           
  Misses        123      123           
  Partials        7        7           
Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 100.00% <ø> (ø)
Pages 98.81% <ø> (ø)
Services 99.36% <ø> (ø)
Shared 99.74% <ø> (ø)
UI 99.21% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 082770a...df9e14e. Read the comment docs.

@codecov-notifications
Copy link

codecov-notifications bot commented Nov 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3488   +/-   ##
=======================================
  Coverage   99.09%   99.09%           
=======================================
  Files         808      808           
  Lines       14402    14402           
  Branches     4093     4100    +7     
=======================================
  Hits        14272    14272           
  Misses        123      123           
  Partials        7        7           
Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 100.00% <ø> (ø)
Pages 98.81% <ø> (ø)
Services 99.36% <ø> (ø)
Shared 99.74% <ø> (ø)
UI 99.21% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 082770a...df9e14e. Read the comment docs.

@codecov-releaser
Copy link
Contributor

codecov-releaser commented Nov 12, 2024

✅ Deploy preview for gazebo ready!

Previews expire after 1 month automatically.

Storybook

Commit Created Cloud Enterprise
f1d40ac Tue, 12 Nov 2024 18:30:49 GMT Expired Expired
a53aa9d Tue, 12 Nov 2024 19:38:47 GMT Expired Expired
aa39119 Tue, 12 Nov 2024 21:01:03 GMT Expired Expired
df9e14e Tue, 12 Nov 2024 21:37:44 GMT Cloud Enterprise

package.json Outdated
@@ -176,7 +176,8 @@
"micromatch": "^4.0.8",
"express": "^4.21.0",
"path-to-regexp@^1.7.0": "^1.9.0",
"path-to-regexp@^6.2.0": "^6.3.0"
"path-to-regexp@^6.2.0": "^6.3.0",
"http-proxy-middleware": "^2.0.7"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we still need this if we're also updating it above?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ahh sorry, I should have clarified in the PR comment that we also use the pckage. The update above was for our own use but we need the resolution for react-scripts since we can't upgrade that.

@calvin-codecov calvin-codecov added this pull request to the merge queue Nov 12, 2024
Merged via the queue into main with commit ef89bf1 Nov 12, 2024
62 checks passed
@calvin-codecov calvin-codecov deleted the cy/vuln_971 branch November 12, 2024 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants