-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: PR comments for rejectNetworkError and using Const values #3484
fix: PR comments for rejectNetworkError and using Const values #3484
Conversation
Bundle ReportChanges will increase total bundle size by 207.75kB (1.19%) ⬆️. This is within the configured threshold ✅ Detailed changes
|
Bundle ReportChanges will increase total bundle size by 418.81kB (2.42%) ⬆️. This is within the configured threshold ✅ Detailed changes
|
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## tests-analytics-v2 #3484 +/- ##
======================================================
- Coverage 99.09% 99.01% -0.08%
======================================================
Files 810 812 +2
Lines 14416 14459 +43
Branches 4101 4121 +20
======================================================
+ Hits 14285 14317 +32
- Misses 124 133 +9
- Partials 7 9 +2
... and 14 files with indirect coverage changes
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## tests-analytics-v2 #3484 +/- ##
======================================================
- Coverage 99.09% 99.01% -0.08%
======================================================
Files 810 812 +2
Lines 14416 14459 +43
Branches 4101 4121 +20
======================================================
+ Hits 14285 14317 +32
- Misses 124 133 +9
- Partials 7 9 +2
... and 14 files with indirect coverage changes
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## tests-analytics-v2 #3484 +/- ##
======================================================
- Coverage 99.09% 99.01% -0.08%
======================================================
Files 810 812 +2
Lines 14416 14459 +43
Branches 4108 4121 +13
======================================================
+ Hits 14285 14317 +32
- Misses 124 133 +9
- Partials 7 9 +2
... and 14 files with indirect coverage changes
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## tests-analytics-v2 #3484 +/- ##
======================================================
- Coverage 99.09% 99.01% -0.08%
======================================================
Files 810 812 +2
Lines 14416 14459 +43
Branches 4101 4114 +13
======================================================
+ Hits 14285 14317 +32
- Misses 124 133 +9
- Partials 7 9 +2
... and 14 files with indirect coverage changes
Continue to review full report in Codecov by Sentry.
|
✅ Deploy preview for gazebo ready!Previews expire after 1 month automatically.
|
Description
This PR follows up on a few comments on the tests-analytics-v2 branch to do the following:
Screenshots
Link to Sample Entry
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.