Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: PR comments for rejectNetworkError and using Const values #3484

Merged

Conversation

ajay-sentry
Copy link
Contributor

Description

This PR follows up on a few comments on the tests-analytics-v2 branch to do the following:

  • Use const values instead of strings for TestResultsFilterParameter
  • Update the hooks reject errors from Promise.reject to rejectNetworkError

Screenshots

Link to Sample Entry

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

@codecov-staging
Copy link

codecov-staging bot commented Nov 11, 2024

Bundle Report

Changes will increase total bundle size by 207.75kB (1.19%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
gazebo-staging-system-esm 5.83MB 251 bytes (0.0%) ⬆️
gazebo-staging-system 5.77MB 207.5kB (3.73%) ⬆️

Copy link

codecov bot commented Nov 11, 2024

Bundle Report

Changes will increase total bundle size by 418.81kB (2.42%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
gazebo-production-system 5.77MB 207.5kB (3.73%) ⬆️
gazebo-production-system-esm 5.83MB 211.31kB (3.76%) ⬆️

@codecov-notifications
Copy link

codecov-notifications bot commented Nov 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@                  Coverage Diff                   @@
##           tests-analytics-v2    #3484      +/-   ##
======================================================
- Coverage               99.09%   99.01%   -0.08%     
======================================================
  Files                     810      812       +2     
  Lines                   14416    14459      +43     
  Branches                 4101     4121      +20     
======================================================
+ Hits                    14285    14317      +32     
- Misses                    124      133       +9     
- Partials                    7        9       +2     
Files with missing lines Coverage Δ
.../FailedTestsPage/MetricsSection/MetricsSection.tsx 91.86% <100.00%> (+0.61%) ⬆️
...ge/hooks/useFlakeAggregates/useFlakeAggregates.tsx 100.00% <100.00%> (ø)
.../useInfiniteTestResults/useInfiniteTestResults.tsx 100.00% <100.00%> (ø)
...TestResultsAggregates/useTestResultsAggregates.tsx 100.00% <100.00%> (ø)
.../hooks/useTestResultsFlags/useTestResultsFlags.tsx 100.00% <100.00%> (ø)
...TestResultsTestSuites/useTestResultsTestSuites.tsx 100.00% <100.00%> (ø)

... and 14 files with indirect coverage changes

Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 100.00% <ø> (ø)
Pages 98.68% <100.00%> (-0.13%) ⬇️
Services 99.36% <ø> (-0.01%) ⬇️
Shared 99.74% <ø> (ø)
UI 99.15% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b652a05...9be84e9. Read the comment docs.

Copy link

codecov-public-qa bot commented Nov 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.01%. Comparing base (b652a05) to head (9be84e9).

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@                  Coverage Diff                   @@
##           tests-analytics-v2    #3484      +/-   ##
======================================================
- Coverage               99.09%   99.01%   -0.08%     
======================================================
  Files                     810      812       +2     
  Lines                   14416    14459      +43     
  Branches                 4101     4121      +20     
======================================================
+ Hits                    14285    14317      +32     
- Misses                    124      133       +9     
- Partials                    7        9       +2     
Files Coverage Δ
.../FailedTestsPage/MetricsSection/MetricsSection.tsx 91.86% <100.00%> (+0.61%) ⬆️
...ge/hooks/useFlakeAggregates/useFlakeAggregates.tsx 100.00% <100.00%> (ø)
.../useInfiniteTestResults/useInfiniteTestResults.tsx 100.00% <100.00%> (ø)
...TestResultsAggregates/useTestResultsAggregates.tsx 100.00% <100.00%> (ø)
.../hooks/useTestResultsFlags/useTestResultsFlags.tsx 100.00% <100.00%> (ø)
...TestResultsTestSuites/useTestResultsTestSuites.tsx 100.00% <100.00%> (ø)

... and 14 files with indirect coverage changes

Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 100.00% <ø> (ø)
Pages 98.68% <100.00%> (-0.13%) ⬇️
Services 99.36% <ø> (-0.01%) ⬇️
Shared 99.74% <ø> (ø)
UI 99.15% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b652a05...9be84e9. Read the comment docs.

Copy link

codecov bot commented Nov 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.01%. Comparing base (b652a05) to head (9be84e9).
Report is 1 commits behind head on tests-analytics-v2.

✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@                  Coverage Diff                   @@
##           tests-analytics-v2    #3484      +/-   ##
======================================================
- Coverage               99.09%   99.01%   -0.08%     
======================================================
  Files                     810      812       +2     
  Lines                   14416    14459      +43     
  Branches                 4108     4121      +13     
======================================================
+ Hits                    14285    14317      +32     
- Misses                    124      133       +9     
- Partials                    7        9       +2     
Files with missing lines Coverage Δ
.../FailedTestsPage/MetricsSection/MetricsSection.tsx 91.86% <100.00%> (+0.61%) ⬆️
...ge/hooks/useFlakeAggregates/useFlakeAggregates.tsx 100.00% <100.00%> (ø)
.../useInfiniteTestResults/useInfiniteTestResults.tsx 100.00% <100.00%> (ø)
...TestResultsAggregates/useTestResultsAggregates.tsx 100.00% <100.00%> (ø)
.../hooks/useTestResultsFlags/useTestResultsFlags.tsx 100.00% <100.00%> (ø)
...TestResultsTestSuites/useTestResultsTestSuites.tsx 100.00% <100.00%> (ø)

... and 14 files with indirect coverage changes

Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 100.00% <ø> (ø)
Pages 98.68% <100.00%> (-0.13%) ⬇️
Services 99.36% <ø> (-0.01%) ⬇️
Shared 99.74% <ø> (ø)
UI 99.15% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b652a05...9be84e9. Read the comment docs.

@codecov-qa
Copy link

codecov-qa bot commented Nov 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.01%. Comparing base (b652a05) to head (9be84e9).
Report is 1 commits behind head on tests-analytics-v2.

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@                  Coverage Diff                   @@
##           tests-analytics-v2    #3484      +/-   ##
======================================================
- Coverage               99.09%   99.01%   -0.08%     
======================================================
  Files                     810      812       +2     
  Lines                   14416    14459      +43     
  Branches                 4101     4114      +13     
======================================================
+ Hits                    14285    14317      +32     
- Misses                    124      133       +9     
- Partials                    7        9       +2     
Files with missing lines Coverage Δ
.../FailedTestsPage/MetricsSection/MetricsSection.tsx 91.86% <100.00%> (+0.61%) ⬆️
...ge/hooks/useFlakeAggregates/useFlakeAggregates.tsx 100.00% <100.00%> (ø)
.../useInfiniteTestResults/useInfiniteTestResults.tsx 100.00% <100.00%> (ø)
...TestResultsAggregates/useTestResultsAggregates.tsx 100.00% <100.00%> (ø)
.../hooks/useTestResultsFlags/useTestResultsFlags.tsx 100.00% <100.00%> (ø)
...TestResultsTestSuites/useTestResultsTestSuites.tsx 100.00% <100.00%> (ø)

... and 14 files with indirect coverage changes

Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 100.00% <ø> (ø)
Pages 98.68% <100.00%> (-0.13%) ⬇️
Services 99.36% <ø> (-0.01%) ⬇️
Shared 99.74% <ø> (ø)
UI 99.15% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b652a05...9be84e9. Read the comment docs.

@codecov-releaser
Copy link
Contributor

codecov-releaser commented Nov 11, 2024

✅ Deploy preview for gazebo ready!

Previews expire after 1 month automatically.

Storybook

Commit Created Cloud Enterprise
5e96c53 Mon, 11 Nov 2024 18:05:06 GMT Expired Expired
9be84e9 Mon, 11 Nov 2024 19:09:54 GMT Cloud Enterprise

@ajay-sentry ajay-sentry merged commit 10a0dde into tests-analytics-v2 Nov 11, 2024
55 of 59 checks passed
@ajay-sentry ajay-sentry deleted the Ajay/ta-reject-network-and-const-updates branch November 11, 2024 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants