Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Incorrect CSS order in Virtual File Renderers #3473

Merged

Conversation

nicholas-codecov
Copy link
Contributor

Description

Quick ordering change of the way we import styles into the virtual file renderers

Screenshots

Before:

Screenshot 2024-11-08 at 09 54 58

After:

Screenshot 2024-11-08 at 09 54 28

Copy link

codecov bot commented Nov 8, 2024

Bundle Report

Bundle size has no change ✅

@codecov-staging
Copy link

codecov-staging bot commented Nov 8, 2024

Bundle Report

Changes will decrease total bundle size by 89 bytes (-0.0%) ⬇️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
gazebo-staging-system-esm* 5.8MB 89 bytes (-0.0%) ⬇️

ℹ️ *Bundle size includes cached data from a previous commit

@codecov-qa
Copy link

codecov-qa bot commented Nov 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.09%. Comparing base (525e497) to head (b05ca92).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3473   +/-   ##
=======================================
  Coverage   99.09%   99.09%           
=======================================
  Files         804      804           
  Lines       14187    14187           
  Branches     4024     4024           
=======================================
  Hits        14058    14058           
  Misses        120      120           
  Partials        9        9           
Files with missing lines Coverage Δ
src/ui/VirtualRenderers/VirtualDiffRenderer.tsx 98.90% <ø> (ø)
src/ui/VirtualRenderers/VirtualFileRenderer.tsx 98.21% <ø> (ø)
Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 100.00% <ø> (ø)
Pages 98.80% <ø> (ø)
Services 99.36% <ø> (ø)
Shared 99.74% <ø> (ø)
UI 99.15% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 525e497...b05ca92. Read the comment docs.

Copy link

codecov bot commented Nov 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.09%. Comparing base (525e497) to head (b05ca92).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3473   +/-   ##
=======================================
  Coverage   99.09%   99.09%           
=======================================
  Files         804      804           
  Lines       14187    14187           
  Branches     4017     4024    +7     
=======================================
  Hits        14058    14058           
  Misses        120      120           
  Partials        9        9           
Files with missing lines Coverage Δ
src/ui/VirtualRenderers/VirtualDiffRenderer.tsx 98.90% <ø> (ø)
src/ui/VirtualRenderers/VirtualFileRenderer.tsx 98.21% <ø> (ø)
Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 100.00% <ø> (ø)
Pages 98.80% <ø> (ø)
Services 99.36% <ø> (ø)
Shared 99.74% <ø> (ø)
UI 99.15% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 525e497...b05ca92. Read the comment docs.

@codecov-notifications
Copy link

codecov-notifications bot commented Nov 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3473   +/-   ##
=======================================
  Coverage   99.09%   99.09%           
=======================================
  Files         804      804           
  Lines       14187    14187           
  Branches     4024     4024           
=======================================
  Hits        14058    14058           
  Misses        120      120           
  Partials        9        9           
Files with missing lines Coverage Δ
src/ui/VirtualRenderers/VirtualDiffRenderer.tsx 98.90% <ø> (ø)
src/ui/VirtualRenderers/VirtualFileRenderer.tsx 98.21% <ø> (ø)
Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 100.00% <ø> (ø)
Pages 98.80% <ø> (ø)
Services 99.36% <ø> (ø)
Shared 99.74% <ø> (ø)
UI 99.15% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 525e497...b05ca92. Read the comment docs.

Copy link

codecov-public-qa bot commented Nov 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.09%. Comparing base (525e497) to head (b05ca92).

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3473   +/-   ##
=======================================
  Coverage   99.09%   99.09%           
=======================================
  Files         804      804           
  Lines       14187    14187           
  Branches     4017     4024    +7     
=======================================
  Hits        14058    14058           
  Misses        120      120           
  Partials        9        9           
Files Coverage Δ
src/ui/VirtualRenderers/VirtualDiffRenderer.tsx 98.90% <ø> (ø)
src/ui/VirtualRenderers/VirtualFileRenderer.tsx 98.21% <ø> (ø)
Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 100.00% <ø> (ø)
Pages 98.80% <ø> (ø)
Services 99.36% <ø> (ø)
Shared 99.74% <ø> (ø)
UI 99.15% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 525e497...b05ca92. Read the comment docs.

@codecov-releaser
Copy link
Contributor

codecov-releaser commented Nov 8, 2024

✅ Deploy preview for gazebo ready!

Previews expire after 1 month automatically.

Storybook

Commit Created Cloud Enterprise
b05ca92 Fri, 08 Nov 2024 14:03:10 GMT Expired Expired
b05ca92 Fri, 08 Nov 2024 14:06:17 GMT Cloud Enterprise

@nicholas-codecov nicholas-codecov added this pull request to the merge queue Nov 8, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 8, 2024
@nicholas-codecov nicholas-codecov added this pull request to the merge queue Nov 8, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 8, 2024
@nicholas-codecov nicholas-codecov added this pull request to the merge queue Nov 8, 2024
Merged via the queue into main with commit 96f88d8 Nov 8, 2024
62 checks passed
@nicholas-codecov nicholas-codecov deleted the fix-background-colour-being-applied-to-some-tokens branch November 8, 2024 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants