-
Notifications
You must be signed in to change notification settings - Fork 3
feat: Add Sentry to the bundler plugins #224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
23 commits
Select commit
Hold shift + click to select a range
fd4fcb7
refactor how we define and access the plugin name and version
nsdeschenes d83cb03
setup Sentry in the bundler plugin core
nsdeschenes 26b4a73
add to the plugins
nsdeschenes bd34936
disable telemetry in the integration tests
nsdeschenes b9d057d
update lock file
nsdeschenes 56421c7
add in changeset
nsdeschenes 5f6b20e
fix type issues
nsdeschenes 4c6b2e7
add in fix for next js webpack plugin not using the correct webpack
nsdeschenes 937c3cd
set owner and repo tags
nsdeschenes 8e60f72
add op's to the spans
nsdeschenes 92352c3
collect some more info about meta frameworks and bundlers
nsdeschenes 83c8e0c
add in some more comments
nsdeschenes d04efd9
Update .changeset/green-goats-thank.md
nsdeschenes a8bfd11
actually send the sentry config to the Output constructor
nsdeschenes e23ed03
force transaction span wrapping all of output.write method
nsdeschenes 04dcead
default values to 0 not undefined
nsdeschenes 6343834
manually set the parent span
nsdeschenes 5b16c22
mock out startSpan from Sentry
nsdeschenes c26a9e1
remove mocks for getScope and clone
nsdeschenes 11ac6b9
wrap outer span in a try catch to actually throw any errors if they'r…
nsdeschenes e5ba3cc
bring back early returns if no provider or upload url
nsdeschenes e31749a
add in emitError wrapper
nsdeschenes e167fcb
use common naming for telemetry
nsdeschenes File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,15 @@ | ||
--- | ||
"@codecov/nextjs-webpack-plugin": minor | ||
"@codecov/bundler-plugin-core": minor | ||
"@codecov/remix-vite-plugin": minor | ||
"@codecov/solidstart-plugin": minor | ||
"@codecov/sveltekit-plugin": minor | ||
"@codecov/webpack-plugin": minor | ||
"@codecov/rollup-plugin": minor | ||
"@codecov/astro-plugin": minor | ||
"@codecov/nuxt-plugin": minor | ||
"@codecov/vite-plugin": minor | ||
"@codecov/bundle-analyzer": minor | ||
--- | ||
|
||
Add Sentry to the bundler plugins to start collecting issues and telemetry |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,14 @@ | ||
--- | ||
"@codecov/nextjs-webpack-plugin": patch | ||
"@codecov/bundler-plugin-core": patch | ||
"@codecov/remix-vite-plugin": patch | ||
"@codecov/solidstart-plugin": patch | ||
"@codecov/sveltekit-plugin": patch | ||
"@codecov/webpack-plugin": patch | ||
"@codecov/rollup-plugin": patch | ||
"@codecov/astro-plugin": patch | ||
"@codecov/nuxt-plugin": patch | ||
"@codecov/vite-plugin": patch | ||
--- | ||
|
||
Fix issue not using the correct webpack in the nextjs plugin |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do these 2 keys represent again?
bundler
vs.metaFramework
? On first glance, I would have expected the values to be flipped here with bundler being "astro" and the metaFramework being from the enum from unplugin.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bundler is the underlying bundler (Rollup, Vite, Webpack), this value is derived from Unplugin itself, whereas the meta-framework value is what we pass through as things like Astro are built on-top of bundlers (Vite in this case), bundlers being the "lowest" system in the stack.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got it, thanks!
If we can declare an enum or type for the acceptable strings that may be nice in the future.