Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: log message was not rendered #579

Merged

Conversation

jooola
Copy link
Contributor

@jooola jooola commented Dec 11, 2024

The fstring was missing the f prefix.

@jooola
Copy link
Contributor Author

jooola commented Dec 11, 2024

image

Copy link

codecov bot commented Dec 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.66%. Comparing base (8295b03) to head (78e90f4).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #579      +/-   ##
==========================================
- Coverage   95.67%   95.66%   -0.01%     
==========================================
  Files          86       83       -3     
  Lines        3120     3117       -3     
==========================================
- Hits         2985     2982       -3     
  Misses        135      135              
Flag Coverage Δ
python3.10 ?
python3.11 ?
python3.12 95.92% <100.00%> (ø)
python3.8 ?
python3.9 ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@thomasrockhu-codecov thomasrockhu-codecov merged commit b7033a9 into codecov:main Dec 11, 2024
21 checks passed
@jooola jooola deleted the log-message-was-not-rendered branch December 11, 2024 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants