chore: Remove deprecated plan name field from plan and plan representation types #1070
Conversation
| reason: "Plan representations have used `value` for a while, making the frontend code hard to change" | ||
| ) | ||
| value: String! | ||
| billingRate: String | ||
| baseUnitPrice: Int! |
There was a problem hiding this comment.
sorting these in ascending order for easier parsing
There was a problem hiding this comment.
doing the lords work 🙏
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. 📢 Thoughts on this report? Let us know! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #1070 +/- ##
==========================================
- Coverage 96.02% 96.02% -0.01%
==========================================
Files 828 828
Lines 19447 19441 -6
==========================================
- Hits 18674 18668 -6
Misses 773 773
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
✅ All tests successful. No failed tests were found. 📣 Thoughts on this report? Let Codecov know! | Powered by Codecov |
Purpose/Motivation
This PR removes an unused field to help cleanup the plan types that we have and reduce some noise. If we plan on combining the types into one in the future this will make our life just a little bit easier.
Closes codecov/engineering-team#3141
Notes to Reviewer
No references in gazebo that I could see, this looks safe to remove.
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.