-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add success after failed payment email (and fix card in failed-payment email) #1065
feat: Add success after failed payment email (and fix card in failed-payment email) #1065
Conversation
@@ -70,9 +101,13 @@ def invoice_payment_failed(self, invoice: stripe.Invoice) -> None: | |||
admins = get_all_admins_for_owners(owners) | |||
|
|||
task_service = TaskService() | |||
payment_intent = stripe.PaymentIntent.retrieve( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Turns out you gotta go get the card in the PaymentIntent explicitly. Annoying that it's another fetch, but oh well, this code isn't time critical enough for that to matter.
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #1065 +/- ##
=======================================
Coverage 96.02% 96.02%
=======================================
Files 828 828
Lines 19434 19444 +10
=======================================
+ Hits 18661 18671 +10
Misses 773 773
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. 📢 Thoughts on this report? Let us know! |
✅ All tests successful. No failed tests were found. 📣 Thoughts on this report? Let Codecov know! | Powered by Codecov |
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
This PR adds the logic for sending the new success-after-failed-payment email template. It also addresses a bug where the card wasn't being properly populated on the other failed-payment email.
Closes codecov/engineering-team#2503
Closes codecov/engineering-team#3119