Feature-list-codecheckers #52
Conversation
|
@nuest just realized there is a discrepancy between the actual number of codechecks and the number of codechecks written on this page. This has to do with the fact that for some codechecks there is more than one author hence those codechecks are counted more than once. The total no. of codechecks as shown above is = sum of entries in the "no.of codechecks" column but the "no. of codechecks" column does not account for this double counting. Should I change the subtitle to show total codechecks without double count and leave the no. of codechecks column as is? A bit confusing for a user if they add up the "no. of codechecks" and see the numbers dont match but the best solution I could think of. Possibly adding a small text stating that some codechecks have multiple authors? |
|
Yes, change the number to checks without double count and please do add a short info about the reason for the discrepancy (though I don't think readers will take time to do the math ;-) ). |
|
@nuest let me know what you think of this. I'll also open this PR for review again and merge once you're good with it. I already incorporated changes based on your comments in the previous PR.
|
|
LGTM! Good to see he tests are back in line, too. |
Solves issue #71
Related codecheck repo PR #90 and PR #97
The render_register function now creates a list of codecheckers as shown in the image below.
The codechecker name links to the codecheck website with all their codechecks.
The orcid ID links to their orcid pages.
The "JSON" links to the index.json file
Changes made:
0.4.0register.Rto a newinst/extdata/config.Rfile.render_table_codecheckersfor html and json files which are now called in render_register functioninst/extdata/templatesfolder in this repo