Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Revive for more recent android sdk versions #208

Draft
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

jspaetzel
Copy link

@jspaetzel jspaetzel commented Aug 22, 2024

I noticed this app was removed from the app store while recommending it to a friend, was still installed from before being removed from the store on my device. https://play.google.com/store/apps/details?id=com.codebutler.farebot

Here's are initial changes to get this working with more recent versions of android. Quick overview of changes in this PR

  • Change namespace def from AndroidManifest to gradle config
  • Update all dependencies. Gradle 8.5, Kotlin 1.9, Java 17, etc.
  • Remove RxBroadcast which hasn't been maintained
  • Resolve Android permission errors

I'm not an android developer so this might be a little rough around the edges, from what i can tell this works on a virtual device and my Pixel 7.

Unfinished here which I'll try to revisit later

  • broke some of the release config, will need to fix to sign a release build
  • clipboard feature in export history doesn't work, not sure if this is related to my changes

@jspaetzel jspaetzel marked this pull request as draft August 22, 2024 01:09
@jspaetzel
Copy link
Author

jspaetzel commented Aug 22, 2024

Tested these changes briefly on a virtual device and a physical device and looks like it's working. 🥳

@jspaetzel jspaetzel changed the title WIP: Update for more recent sdk WIP: Revive for more recent android sdk versions Aug 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant