Skip to content

Commit

Permalink
Refactor Require statements to never call functions directly
Browse files Browse the repository at this point in the history
- Move function calls from require statements
- This makes the code easier to read ...
- ... and will make transfer to ES6 import easier
  • Loading branch information
codebru committed Jul 18, 2019
1 parent 9cfda6e commit facf99d
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 4 deletions.
4 changes: 3 additions & 1 deletion Components/Example/index.js
Original file line number Diff line number Diff line change
@@ -1,8 +1,10 @@
/* INCLUDES ******************************* */
const example = require('express').Router();
const express = require('express');
/* **************************************** */

/* ROUTES ********************************* */
const example = express.Router();

example.get('/', (req, res) => {
res.status(200);
res.send('SUCCESS');
Expand Down
4 changes: 3 additions & 1 deletion Components/User/index.js
Original file line number Diff line number Diff line change
@@ -1,10 +1,12 @@
/* INCLUDES ****************************** */
const router = require('express').Router();
const express = require('express');
const passport = require('passport');
const { isAlreadyAuthenticated } = require('./../../Utils/Passport/auth');
/* **************************************** */

/* ROUTES ********************************* */
const router = express.Router();

router.post('/login', isAlreadyAuthenticated, (req, res, next) => {
passport.authenticate('local', {
successRedirect: '/example',
Expand Down
5 changes: 3 additions & 2 deletions index.js
Original file line number Diff line number Diff line change
Expand Up @@ -4,11 +4,12 @@ const session = require('express-session');
const passport = require('passport');
const flash = require('flash');
const bodyParser = require('body-parser');
const dotenv = require('dotenv');
const passportConfig = require('./Utils/Passport/config');
/* **************************************** */

/* INCLUDE CONFIGS ************************ */
require('dotenv').config();
const passportConfig = require('./Utils/Passport/config');
dotenv.config();
/* **************************************** */

/* INCLUDE ROUTES ************************ */
Expand Down

0 comments on commit facf99d

Please sign in to comment.