Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minMaxLoc() and minMaxIdx() #18

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

ayapi
Copy link

@ayapi ayapi commented Dec 30, 2013

I felt something is a little off about cv.minMaxLoc().

http://docs.opencv.org/modules/core/doc/operations_on_arrays.html?highlight=minmaxloc#minmaxloc
Python: cv2.minMaxLoc(src[, mask]) → minVal, maxVal, minLoc, maxLoc
C: void cvMinMaxLoc(const CvArr* arr, double* min_val, double* max_val, CvPoint* min_loc=NULL, CvPoint* max_loc=NULL, const CvArr* mask=NULL )

So I thought about how I wish I could write (src, minVal, maxVal, minLoc, maxLoc, mask) style args like Python.
And minMaxIdx() can be substituted for minMaxLoc(src, minVal, maxVal, minIdx, maxIdx).

Please consider it.

@codeboost
Copy link
Owner

Still on vacation now, will take a look when I get back to my dev machine. Thanks for contributing !

@ayapi
Copy link
Author

ayapi commented Jan 4, 2014

Thank you! Have a nice vacation : )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants