wip

codebar-ag · Sep 20, 2023 · a64725d · a64725d
1 parent c220980
commit a64725d
Show file tree

Hide file tree

Showing 5 changed files with 4 additions and 79 deletions.
diff --git a/phpunit.xml.dist b/phpunit.xml.dist
@@ -16,7 +16,7 @@
         <junit outputFile="build/report.junit.xml"/>
     </logging>
     <php>
-        <env name="ZENDESK_ENDPOINT" value=""/>
+        <env name="ZENDESK_SUBDOMAIN" value=""/>
         <env name="ZENDESK_EMAIL_ADDRESS" value=""/>
         <env name="ZENDESK_API_TOKEN" value=""/>
     </php>

diff --git a/src/Requests/CreateSingleTicketRequest.php b/src/Requests/CreateSingleTicketRequest.php
@@ -22,22 +22,10 @@ public function resolveEndpoint(): string
     }
 
     public function __construct(
-        readonly protected array|SingleTicketDTO $createTicket,
-        readonly protected ?string $onBehalfOf = null,
+        readonly protected array|SingleTicketDTO $createTicket
     ) {
     }
 
-    protected function defaultHeaders(): array
-    {
-        $headers = [];
-
-        if ($this->onBehalfOf) {
-            $headers['X-On-Behalf-Of'] = $this->onBehalfOf;
-        }
-
-        return $headers;
-    }
-
     protected function defaultBody(): array
     {
         $body = $this->createTicket;

diff --git a/src/Requests/ShowUserRequest.php b/src/Requests/ShowUserRequest.php
diff --git a/tests/Connectors/ZendeskConnectorTest.php b/tests/Connectors/ZendeskConnectorTest.php
@@ -2,10 +2,12 @@
 
 use CodebarAg\Zendesk\Requests\SingleTicketRequest;
 use CodebarAg\Zendesk\ZendeskConnector;
+use Illuminate\Support\Facades\Config;
 use Saloon\Http\Faking\MockResponse;
 use Saloon\Laravel\Http\Faking\MockClient;
 
 it('will throw an exception if a subdomain is not set', closure: function () {
+    Config::set('zendesk.subdomain');
     $connector = new ZendeskConnector;
     $connector->resolveBaseUrl();
 

diff --git a/tests/Requests/ShowUserRequestTest.php b/tests/Requests/ShowUserRequestTest.php