Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sadman Sakib #394

Merged
merged 2 commits into from
Oct 23, 2024
Merged

Sadman Sakib #394

merged 2 commits into from
Oct 23, 2024
+17 −0

Conversation

Sadman95
Copy link
Contributor

Description

I have added my personal JSON data

Related Issues

Changes Proposed

  • added Sadman95.json file in the data sets under public/data
  • point the file in ProfileList.json file

Checklist

  • [✓] I have read and followed the Contribution Guidelines.
  • [✓] All new and existing tests passed.
  • [✓] I have updated the documentation to reflect the changes I've made.
  • [✓] My code follows the code style of this project.
  • [✓] The title of my pull request is a short description of the requested changes.

Screenshots

Note to reviewers

@vercel Vercel
Copy link

vercel bot commented Oct 23, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
devdisplay ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 23, 2024 8:16am

@netlify Netlify
Copy link

netlify bot commented Oct 23, 2024 •
edited
Loading

✅ Deploy Preview for devdisplay ready!

Name Link
🔨 Latest commit 73a4263
🔍 Latest deploy log https://app.netlify.com/sites/devdisplay/deploys/6718b0ae0729ab0008f0d5ec
😎 Deploy Preview https://deploy-preview-394--devdisplay.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ishap11 ishap11 merged commit de04387 into codeaashu:main Oct 23, 2024
6 checks passed
@ishap11 ishap11 self-requested a review October 23, 2024 08:16
@ishap11 ishap11 added hacktoberfest Label is used for Issues and pull request related to Hacktoberfest 2024 open source contribution. hacktoberfest2024 Label for tracking contributions and activities during Hacktoberfest 2024 hacktoberfest-accepted Label is used for accept the pull request of contributer in Hacktoberfest 2024. gssoc-ext Label is used for Issues and pull request related to GSSOC 2024 open source contribution. level1 labels Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ishap11 ishap11 Awaiting requested review from ishap11

Assignees

@Sadman95 Sadman95

Labels
gssoc-ext Label is used for Issues and pull request related to GSSOC 2024 open source contribution. hacktoberfest Label is used for Issues and pull request related to Hacktoberfest 2024 open source contribution. hacktoberfest2024 Label for tracking contributions and activities during Hacktoberfest 2024 hacktoberfest-accepted Label is used for accept the pull request of contributer in Hacktoberfest 2024. level1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Sadman95 @ishap11