Upgrades HackathonManager to Rails 7 #964

cbaudouinjr · 2024-02-05T02:08:52Z

It's been a while, huh? After many years and many failed attempts, HackathonManager is now on Rails 7!

There's still plenty of work to go before a release can happen, but this is by far the biggest step.

Unfortunately, this pull request is massive. When I first started this attempt I had little hope and didn't bother with creating bitesized PRs. Fortunately, most of the core application hasn't changed, rather, updated to removed deprecations and other outdates pieces. I made each commit as small as possible, and ran tests for each commit.

I'll try to highlight below where you should look for the biggest changes and which are mostly likely to break.

What's new

Upgrade to Rails 7 and Ruby 3 A small detail, I know.
Goodbye ajax-datatables-rails! All datatables have been replaced with datatables created with Turbo and Stimulus. This has significantly reduced the amount and complexity of code around a datatable.
Many, many gem updates Most of the gems have been updated to a more recent version. Some are held back as they require more intensive refactoring that's outside the scope of this PR. *cough* rails-settings-cached
Gitflow HackathonManager will transition into the Gitflow workflow for easier organization and planning.

What to review

Datatables There are many changes still to come for the datatables but the general approach should be reviewed. I would look at the questionnaires datatable found in views->manage->questionnaires->_questionnaires_datatable.html.haml. The flow of data starts from the controller then goes to the page hosting the table. From there, the data is fed into the partial.

Closes #965, #966

…bles

Gemfile

app/views/manage/schools/_schools_datatable.html.haml

houndci-bot · 2024-02-05T02:09:18Z

app/views/manage/checkins/_checkins_datatable.html.haml

+            .col
+              = pagy_bootstrap_nav(@applicants_pagy).html_safe
+  - else
+    %div{ style: "display:flex; align-items: center; flex-direction: column;" }


Do not use inline style attributes

houndci-bot · 2024-02-05T02:09:18Z

app/javascript/controllers/application.js

+const application = Application.start()
+
+// Configure Stimulus development experience
+application.debug = false


Missing semicolon.

houndci-bot · 2024-02-05T02:09:18Z

app/javascript/controllers/application.js

@@ -0,0 +1,9 @@
+import { Application } from "@hotwired/stimulus"
+
+const application = Application.start()


'const' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).
Missing semicolon.

houndci-bot · 2024-02-05T02:09:18Z

app/javascript/controllers/application.js

@@ -0,0 +1,9 @@
+import { Application } from "@hotwired/stimulus"


'import' is only available in ES6 (use 'esversion: 6').
Missing semicolon.

houndci-bot · 2024-02-05T02:09:19Z

app/javascript/controllers/form_controller.js

+  }
+
+  submit() {
+    this.element.requestSubmit()


Missing semicolon.

houndci-bot · 2024-02-05T02:09:19Z

app/javascript/controllers/form_controller.js

+
+export default class extends Controller {
+  initialize() {
+    this.submit = debounce(this.submit.bind(this), 300)


Missing semicolon.

houndci-bot · 2024-02-05T02:13:08Z

app/javascript/controllers/form_controller.js

+import { Controller } from "@hotwired/stimulus";
+import debounce from "debounce";
+
+export default class extends Controller {


'class' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).
'export' is only available in ES6 (use 'esversion: 6').

houndci-bot · 2024-02-05T02:13:09Z

app/javascript/controllers/form_controller.js

@@ -0,0 +1,12 @@
+import { Controller } from "@hotwired/stimulus";
+import debounce from "debounce";


'import' is only available in ES6 (use 'esversion: 6').

houndci-bot · 2024-02-05T02:13:09Z

app/javascript/controllers/form_controller.js

@@ -0,0 +1,12 @@
+import { Controller } from "@hotwired/stimulus";


'import' is only available in ES6 (use 'esversion: 6').

app/models/message.rb

app/views/manage/application/_questionnaires_datatable.html.haml

db/seeds/development.rb

houndci-bot · 2024-02-05T02:13:09Z

app/javascript/controllers/index.js

+
+// Eager load all controllers defined in the import map under controllers/**/*_controller
+import { eagerLoadControllersFrom } from "@hotwired/stimulus-loading"
+eagerLoadControllersFrom("controllers", application)


Missing semicolon.

houndci-bot · 2024-02-05T02:13:09Z

app/javascript/controllers/index.js

+import { application } from "controllers/application"
+
+// Eager load all controllers defined in the import map under controllers/**/*_controller
+import { eagerLoadControllersFrom } from "@hotwired/stimulus-loading"


'import' is only available in ES6 (use 'esversion: 6').
Missing semicolon.

houndci-bot · 2024-02-05T02:13:10Z

app/javascript/controllers/index.js

@@ -0,0 +1,11 @@
+// Import and register all your controllers from the importmap under controllers/*
+
+import { application } from "controllers/application"


'import' is only available in ES6 (use 'esversion: 6').
Missing semicolon.

app/models/agreement.rb

houndci-bot · 2024-02-05T02:21:12Z

app/views/manage/messages/_bulk_messages_datatable.html.haml

+              = pagy_bootstrap_nav(@bulk_messages_pagy).html_safe
+
+  - else
+    %div{ style: "display:flex; align-items: center; flex-direction: column;" }


Do not use inline style attributes

app/models/bus_list.rb

houndci-bot · 2024-02-05T02:21:13Z

db/migrate/20240105050612_create_active_storage_variant_records.active_storage.rb

+      config.options[config.orm][:primary_key_type] || :primary_key
+    end
+
+    def blobs_primary_key_type


Layout/IndentationConsistency: Inconsistent indentation detected.

houndci-bot · 2024-02-05T02:21:13Z

db/migrate/20240105050612_create_active_storage_variant_records.active_storage.rb

+  end
+
+  private
+    def primary_key_type


Layout/IndentationConsistency: Inconsistent indentation detected.

houndci-bot · 2024-02-05T02:21:13Z

db/migrate/20240105050612_create_active_storage_variant_records.active_storage.rb

+    end
+  end
+
+  private


Layout/EmptyLinesAroundAccessModifier: Keep a blank line before and after private.

houndci-bot · 2024-02-05T02:21:13Z

app/views/manage/stats/_alt_travel_datatable.html.haml

+            .col
+              = pagy_bootstrap_nav(@alt_travel_applicants_pagy).html_safe
+  - else
+    %div{ style: "display:flex; align-items: center; flex-direction: column;" }


Do not use inline style attributes

houndci-bot · 2024-02-05T02:21:13Z

app/views/manage/stats/_applied_datatable.html.haml

+            .col
+              = pagy_bootstrap_nav(@applied_pagy).html_safe
+  - else
+    %div{ style: "display:flex; align-items: center; flex-direction: column;" }


Do not use inline style attributes

houndci-bot · 2024-02-05T02:21:13Z

app/views/manage/stats/_attendee_sponsor_info_datatable.html.haml

+            .col
+              = pagy_bootstrap_nav(@sponsor_info_attendees_pagy).html_safe
+  - else
+    %div{ style: "display:flex; align-items: center; flex-direction: column;" }


Do not use inline style attributes

houndci-bot · 2024-02-05T02:21:14Z

app/views/manage/stats/_checked_in_datatable.html.haml

+            .col
+              = pagy_bootstrap_nav(@checked_in_applicants_pagy).html_safe
+  - else
+    %div{ style: "display:flex; align-items: center; flex-direction: column;" }


Do not use inline style attributes

houndci-bot · 2024-02-05T02:21:14Z

app/views/manage/stats/_dietary_restrictions_special_needs_restrictions_datatable.html.haml

+            .col
+              = pagy_bootstrap_nav(@dietary_restrictions_special_needs_pagy).html_safe
+  - else
+    %div{ style: "display:flex; align-items: center; flex-direction: column;" }


Do not use inline style attributes

houndci-bot · 2024-02-05T02:31:25Z

app/views/manage/trackable_tags/_trackable_tags_datatable.html.haml

+            .col
+              = pagy_bootstrap_nav(@trackable_tags_pagy).html_safe
+  - else
+    %div{ style: "display:flex; align-items: center; flex-direction: column;" }


Do not use inline style attributes

houndci-bot · 2024-02-05T02:31:25Z

db/migrate/20240105050611_add_service_name_to_active_storage_blobs.active_storage.rb

+    unless column_exists?(:active_storage_blobs, :service_name)
+      add_column :active_storage_blobs, :service_name, :string
+
+      if configured_service = ActiveStorage::Blob.service.name


Lint/AssignmentInCondition: Use == if you meant to do a comparison or wrap the expression in parentheses to indicate you meant to assign in a condition.

houndci-bot · 2024-02-05T03:21:10Z

app/models/agreement.rb

@@ -7,6 +9,10 @@ class Agreement < ApplicationRecord

  has_and_belongs_to_many :questionnaires

+  def self.ransackable_attributes(_)


Naming/UncommunicativeMethodParamName: Method parameter must be at least 3 characters long.

houndci-bot · 2024-02-05T03:21:10Z

app/models/bus_list.rb


  has_many :questionnaires

  strip_attributes

+  def self.ransackable_attributes(_)


Naming/UncommunicativeMethodParamName: Method parameter must be at least 3 characters long.

houndci-bot · 2024-02-05T03:21:10Z

app/models/message.rb

@@ -49,6 +51,10 @@ class Message < ApplicationRecord
  validates_inclusion_of :template, in: POSSIBLE_TEMPLATES
  validates_inclusion_of :type, in: POSSIBLE_TYPES

+  def self.ransackable_attributes(_)


Naming/UncommunicativeMethodParamName: Method parameter must be at least 3 characters long.

houndci-bot · 2024-02-05T03:21:11Z

app/models/questionnaire.rb

@@ -323,6 +325,10 @@ class Questionnaire < ApplicationRecord
  validates_inclusion_of :shirt_size, in: POSSIBLE_SHIRT_SIZES
  validates_inclusion_of :acc_status, in: POSSIBLE_ACC_STATUS

+  def self.ransackable_attributes(_)


Naming/UncommunicativeMethodParamName: Method parameter must be at least 3 characters long.

houndci-bot · 2024-02-05T03:21:11Z

app/models/school.rb


  strip_attributes

  has_many :questionnaires

+  def self.ransackable_attributes(_)


Naming/UncommunicativeMethodParamName: Method parameter must be at least 3 characters long.

houndci-bot · 2024-02-05T03:21:11Z

app/models/user.rb

+    ["created_at", "current_sign_in_at", "current_sign_in_ip", "email", "first_name", "id", "is_active", "last_name", "last_sign_in_at", "last_sign_in_ip", "provider", "receive_weekly_report", "role", "uid"]
+  end
+
+  def self.ransackable_associations(_)


Naming/UncommunicativeMethodParamName: Method parameter must be at least 3 characters long.

houndci-bot · 2024-02-05T03:21:11Z

app/models/user.rb

  validates_presence_of :first_name, :last_name

  after_create :queue_reminder_email
  after_initialize :set_default_role, if: :new_record?

  enum role: { user: 0, volunteer: 1, organizer: 2, director: 3 }
+  scope :staff, -> { where(role: [:volunteer, :organizer, :director]) }
+
+  def self.ransackable_attributes(_)


Naming/UncommunicativeMethodParamName: Method parameter must be at least 3 characters long.

sman591 · 2024-02-09T03:18:47Z

Nice! This is awesome

cbaudouinjr added 30 commits January 1, 2024 20:42

Updates dependencies for 5.2.4.4

e82cac3

Locks factory_bot_rails

00acbae

Locks simple_form, updates oauth test

abb51a8

Reverts questionnaire datatable to legacy format

8c1ea23

Upgrades Rails to 5.2.4.6

5ea6b38

Removes datatable test API params

23a4c34

Updates Rails to 5.2.5

f4657a0

Updates Rails to 5.2.6.3

77d3921

Updates Rails to 5.2.7.1

08f10dd

Updates Rails to 5.2.8.1, adds support for CVE-2022-32224

23ec7aa

Adds support for Rails 5.2 framework defaults

2dda770

Updates Rails to 6.0.0.0, refactors authentication routes

17b08a6

Disables case sensitivity for various models

9e4a170

Refactors update_attributes to update

d426c08

Fixes case sensitive validations for tests

6b72700

Upgrades Ruby to 2.7.8

3c5c239

Fixes tests for Rails 6.0.0, changes login routes

0b69630

Updates Rails to 6.0.6.1

761e831

Adds Rails 6.0 framework defaults

308516c

Starts update to Rails 6.1.7.6

58254a0

Updates Rails to 6.1.7.6

ce14df4

Updates gems to latest for Rails 6.1

dd29f48

Updates Ruby to 3.0.6

8148dd6

Updates Sidekiq and Sidekiq-cron to latest

5e79830

Updates Puma to latest

cc4c9bc

Cleans Gemfile, adds Rails 7 default gems

debab95

Updates Rails to 7.0.8

90773de

Updates gems for Rails 7.0.8

9ac28cf

Removes sprockets-rails

64bd2f8

Converts turbolinks to turbo

7a8c842

cbaudouinjr added 4 commits February 3, 2024 12:03

Replaces alt travel and attendee sponsor datatables with Turbo datata…

cf1b419

…bles

Replaces checkins datatable with Turbo datatable

acd0366

Removes ajax-datatables-rails, completes datatable transition

6ec0b95

Updates README for v3.0.0

b22caad

houndci-bot reviewed Feb 5, 2024

View reviewed changes

Gemfile Outdated Show resolved Hide resolved

houndci-bot reviewed Feb 5, 2024

View reviewed changes

Gemfile Outdated Show resolved Hide resolved

houndci-bot reviewed Feb 5, 2024

View reviewed changes

Gemfile Outdated Show resolved Hide resolved

houndci-bot reviewed Feb 5, 2024

View reviewed changes

Gemfile Outdated Show resolved Hide resolved

houndci-bot reviewed Feb 5, 2024

View reviewed changes

Gemfile Outdated Show resolved Hide resolved

houndci-bot reviewed Feb 5, 2024

View reviewed changes

Updates GitHub workflows for Ruby 3.0.6

42daa46

houndci-bot reviewed Feb 5, 2024

View reviewed changes

Removes application_datatable.rb

e7b90bf

houndci-bot reviewed Feb 5, 2024

View reviewed changes

Changes GitHub Actions to use test database

3d0bc83

houndci-bot reviewed Feb 5, 2024

View reviewed changes

cbaudouinjr added 2 commits February 4, 2024 21:34

Switches workflow to use prepare

fb48738

Switches workflow to migrate

8447da8

cbaudouinjr requested review from peterkos, JeremyRudman, sjmiller7 and sman591 February 5, 2024 02:51

cbaudouinjr added 2 commits February 4, 2024 22:02

Removes duplicate stimulus-rails in Gemfile

db7c871

Fixes several lint issues

9e24058

houndci-bot reviewed Feb 5, 2024

View reviewed changes

cbaudouinjr linked an issue Feb 5, 2024 that may be closed by this pull request

Upgrade to Ruby 3 #966

Closed

JeremyRudman approved these changes Feb 5, 2024

View reviewed changes

cbaudouinjr merged commit 1bad0fb into develop Feb 9, 2024
2 checks passed

cbaudouinjr deleted the upgrade branch February 9, 2024 02:59

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Upgrades HackathonManager to Rails 7 #964

Upgrades HackathonManager to Rails 7 #964

cbaudouinjr commented Feb 5, 2024 •

edited

Loading

houndci-bot Feb 5, 2024

houndci-bot Feb 5, 2024

houndci-bot Feb 5, 2024

houndci-bot Feb 5, 2024

houndci-bot Feb 5, 2024

houndci-bot Feb 5, 2024

houndci-bot Feb 5, 2024

houndci-bot Feb 5, 2024

houndci-bot Feb 5, 2024

houndci-bot Feb 5, 2024

houndci-bot Feb 5, 2024

houndci-bot Feb 5, 2024

houndci-bot Feb 5, 2024

houndci-bot Feb 5, 2024

houndci-bot Feb 5, 2024

houndci-bot Feb 5, 2024

houndci-bot Feb 5, 2024

houndci-bot Feb 5, 2024

houndci-bot Feb 5, 2024

houndci-bot Feb 5, 2024

houndci-bot Feb 5, 2024

houndci-bot Feb 5, 2024

houndci-bot Feb 5, 2024

houndci-bot Feb 5, 2024

houndci-bot Feb 5, 2024

houndci-bot Feb 5, 2024

houndci-bot Feb 5, 2024

houndci-bot Feb 5, 2024

houndci-bot Feb 5, 2024

houndci-bot Feb 5, 2024

sman591 commented Feb 9, 2024

		@@ -0,0 +1,9 @@
		import { Application } from "@hotwired/stimulus"

		const application = Application.start()

		@@ -0,0 +1,12 @@
		import { Controller } from "@hotwired/stimulus";
		import debounce from "debounce";

		@@ -0,0 +1,11 @@
		// Import and register all your controllers from the importmap under controllers/*

		import { application } from "controllers/application"

+                  end
+                end
+                private

		@@ -7,6 +9,10 @@ class Agreement < ApplicationRecord

		has_and_belongs_to_many :questionnaires

		def self.ransackable_attributes(_)

Upgrades HackathonManager to Rails 7 #964

Upgrades HackathonManager to Rails 7 #964

Conversation

cbaudouinjr commented Feb 5, 2024 • edited Loading

What's new

What to review

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sman591 commented Feb 9, 2024

cbaudouinjr commented Feb 5, 2024 •

edited

Loading