Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FEAT(USD balance showcase) adds USD balance #217

Merged
merged 3 commits into from
Oct 10, 2024
Merged

FEAT(USD balance showcase) adds USD balance #217

merged 3 commits into from
Oct 10, 2024

Conversation

prince981620
Copy link
Contributor

USD Balance Showcase

Added functionality to show balance in USD along with SOL

Issue Number: Fixes #215

🛠️ Type of Change

  • 🐛 Bug fix
  • ✨ New feature
  • 🚨 Breaking change
  • 📚 Documentation update

✅ Checklist

To ensure a smooth review process, please check off each item as you complete it:

  • Code Style: My code adheres to the project’s style guidelines.
  • Self-Review: I have reviewed my own code and made improvements.
  • Comments: I’ve added comments to explain complex or non-obvious parts of the code.
  • Documentation: I’ve updated the documentation to reflect my changes.
  • Warnings: My changes introduce no new warnings.
  • Tests: I’ve added tests to verify that my changes work as expected.
  • Passes Locally: All new and existing unit tests pass on my local machine.
Screenshot 2024-10-08 at 4 32 01 AM

Rudra-Sankha-Sinhamahapatra
Rudra-Sankha-Sinhamahapatra reviewed Oct 8, 2024
View reviewed changes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work

src/services/walletService.ts Show resolved Hide resolved
Rudra-Sankha-Sinhamahapatra
Rudra-Sankha-Sinhamahapatra approved these changes Oct 8, 2024
View reviewed changes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good

@cb7chaitanya
Copy link
Collaborator

@prince981620 Resolve merge conflicts

@prince981620
Copy link
Contributor Author

hey @cb7chaitanya conflict resolved, review

@cb7chaitanya cb7chaitanya merged commit 6518364 into code100x:dev Oct 10, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cb7chaitanya cb7chaitanya cb7chaitanya left review comments

@Rudra-Sankha-Sinhamahapatra Rudra-Sankha-Sinhamahapatra Rudra-Sankha-Sinhamahapatra approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEAT] Showcase USD with SOL in balance
3 participants
@prince981620 @cb7chaitanya @Rudra-Sankha-Sinhamahapatra