Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: added encryption of shares #157

Open
wants to merge 1 commit into
base: dev-backend-feature/encryption
Choose a base branch
from

Conversation

lakshayvaishnav
Copy link
Contributor


Feat: added encryption of shares

I've added AES encryption to the shares generated during the secret splitting process. This ensures that even if someone gets their hands on the shares, they won't be able to access the original secret without the proper keys.

#136

🛠️ Type of Change

  • 🐛 Bug fix
  • ✨ New feature
  • 🚨 Breaking change
  • 📚 Documentation update

✅ Checklist

To ensure a smooth review process, please check off each item as you complete it:

  • Code Style: My code adheres to the project’s style guidelines.
  • Self-Review: I have reviewed my own code and made improvements.
  • Comments: I’ve added comments to explain complex or non-obvious parts of the code.
  • Documentation: I’ve updated the documentation to reflect my changes.
  • Warnings: My changes introduce no new warnings.
  • Tests: I’ve added tests to verify that my changes work as expected.
  • Passes Locally: All new and existing unit tests pass on my local machine.

We appreciate your contributions! If you have any questions or need further assistance, feel free to reach out.

@axatbhardwaj
Copy link
Collaborator

Hi @lakshayvaishnav why are we not using IV over here ?

would like to know if it was a deliberate decision and if not then we need to use IV while encrypting

IV

@cb7chaitanya
Copy link
Collaborator

Also we have to handle three shares of the private key right now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants