Skip to content

Implement floating navbar #1806

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Implement floating navbar #1806

wants to merge 2 commits into from

Conversation

DufferDeepu
Copy link

PR Fixes:

    1. Implemented a floating navbar: Changed the static navbar to a floating navbar that sticks at the top when scrolling.
    1. Added required CSS : Updated styles for extra shadow for floating effect.

Checklist before requesting a review

  • I have performed a self-review of my code.
  • I assure there is no similar/duplicate pull request regarding same issue.
  • I have tested the floating navbar functionality in different screen sizes (desktop/mobile).
  • I have verified that no other part of the UI breaks due to these changes.

@geekyharsh05
Copy link
Contributor

@DufferDeepu The navbar is overflowing on mobile view, everything else is fine Great Work!

image

@geekyharsh05
Copy link
Contributor

@DufferDeepu It would be really helpful if you could also share a screenshot of the mobile view output you're seeing on your end.

@DufferDeepu
Copy link
Author

Fix issue with overflow on mobile view
mobile view

@DufferDeepu DufferDeepu mentioned this pull request Apr 6, 2025
Closed
@DufferDeepu
Copy link
Author

@devsargam Please review this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geekyharsh05 geekyharsh05 geekyharsh05 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DufferDeepu @geekyharsh05