Merge pull request #88 from code0-tech/raise-for-invalid-ability-stub…

…bing Raise error when stubbing invalid abilities
code0-tech · Mar 1, 2024 · 88afadd · 88afadd
2 parents 911be26 + 48c42cc
commit 88afadd
Show file tree

Hide file tree

Showing 5 changed files with 8 additions and 5 deletions.
diff --git a/app/models/team_role_ability.rb b/app/models/team_role_ability.rb
@@ -3,7 +3,8 @@
 class TeamRoleAbility < ApplicationRecord
   ABILITIES = {
     create_team_role: 1,
-    read_team_role: 2,
+    invite_member: 2,
+    assign_member_roles: 3,
   }.with_indifferent_access
 
   enum :ability, ABILITIES, prefix: :can

diff --git a/spec/policies/concerns/customizable_permission_spec.rb b/spec/policies/concerns/customizable_permission_spec.rb
@@ -31,10 +31,10 @@
 
   context 'when user has a role with a different ability' do
     before do
-      create(:team_role_ability, team_role: team_role, ability: :read_team_role)
+      create(:team_role_ability, team_role: team_role, ability: :create_team_role)
     end
 
-    it { is_expected.not_to be_allowed(:create_team_role) }
+    it { is_expected.not_to be_allowed(:invite_member) }
   end
 
   it { is_expected.not_to be_allowed(:create_team_role) }

diff --git a/spec/requests/graphql/mutation/team_members/invite_mutation_spec.rb b/spec/requests/graphql/mutation/team_members/invite_mutation_spec.rb
@@ -42,7 +42,6 @@
     before do
       create(:team_member, team: team, user: current_user)
       stub_allowed_ability(TeamPolicy, :invite_member, user: current_user, subject: team)
-      stub_allowed_ability(TeamPolicy, :read_team_member, user: current_user, subject: team)
     end
 
     it 'creates team member' do

diff --git a/spec/requests/graphql/mutation/team_roles/create_mutation_spec.rb b/spec/requests/graphql/mutation/team_roles/create_mutation_spec.rb
@@ -41,7 +41,6 @@
     before do
       create(:team_member, team: team, user: current_user)
       stub_allowed_ability(TeamPolicy, :create_team_role, user: current_user, subject: team)
-      stub_allowed_ability(TeamPolicy, :read_team_role, user: current_user, subject: team)
     end
 
     it 'creates team role' do

diff --git a/spec/support/helpers/stub_ability.rb b/spec/support/helpers/stub_ability.rb
@@ -1,7 +1,11 @@
 # frozen_string_literal: true
 
 module StubAbility
+  InvalidAbility = Class.new(StandardError)
+
   def stub_allowed_ability(policy_class, ability, user: nil, subject: nil)
+    raise InvalidAbility, "Ability #{ability} does not exist" unless TeamRoleAbility::ABILITIES.key?(ability)
+
     # rubocop:disable RSpec/AnyInstance -- policy instances are per user and subject
     allow_any_instance_of(policy_class)
       .to receive(:user_has_ability?)