Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add content_area and topic_tags to dim_course_structure #234

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

jordan-springer
Copy link
Collaborator

@jordan-springer jordan-springer commented Nov 13, 2024

Description

Bringing in content_area and topic_tags from scripts data to expose in dim_course_structure

Additionally, added backup file for course_structure rosetta procedure to deploy in redshift

Links

Jira ticket(s): DATAOPS-1054

Testing story

  • Does your change include appropriate tests on key columns?
    eg.
    - not_null
    - unique
    - `dbt_utils.unique_combination_of_columns: , ["value","value","value"...]

Note: when submitting a new model for review please make sure the following have been tested:

  1. The model compiles (dbt build -m 'your_model')
    or: has the dbt Cloud job succeeded?
  2. The model runs (dbt run -m 'your_model')
  3. The model produces accessible data in the DW (select 1 from 'your_model')

Privacy

  • 1. Does this change involve the collection, use, or sharing of new Personal Data?
  • 2. Do these data exist in the appropriate schema(s)?
  • 3. Does this change involve a new or changed use or sharing of existing Personal Data?
  • 4. Consider: will this data be visible on Tableau? will this data be surfaced in a report exported from Trevor?
  • 5. If yes to any of the above, please list the models, columns, and justification below:
    i.
    ii.
    iii.

PR Checklist:

--> Note: if these are not all checked, the PR will be sent back.

  • Tests provide adequate coverage
  • Privacy and Security impacts have been assessed
  • Code adheres to style guide👀 and is DRY
  • Code is well-commented (**please do not leave extraneous commentary in model code, if it is for the purpose of documentation, please relocate accordingly)
  • Appropriate documentation has been provided (see .yml., did dbt docs generate succeed?)
  • New features are translatable or updates will not break up/downstream models
  • Relevant documentation has been added or updated (i.e. dbt docs has been updated successfully on Github Pages
  • Pull Request is labeled appropriately (eg. chore/, feature/, fix/)
  • Follow-up work items (including potential tech debt) are tracked and linked (if applicable)

@jordan-springer jordan-springer self-assigned this Nov 14, 2024
Copy link
Contributor

@nataliazm99 nataliazm99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't finished reviewing but the 'old' code for analysis.rosetta looks very different, looks like a version previous to the existing one, which makes it hard to review and also makes me worry that we might be missing something that has been changed since. Jordan, can you take a look at that?

dbt/archive/rosetta/02-run_course_structure.sql Outdated Show resolved Hide resolved
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

proposing a change to the student_course_names cte:

student_course_names as (
    select distinct course_name
    from {{ ref('stg_dashboard__scripts') }}
    where participant_audience = 'student'
    and content_area ilike '%curriculum'
),

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants