Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/hoc activities #214

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Fix/hoc activities #214

wants to merge 8 commits into from

Conversation

coryamanda
Copy link
Collaborator

Edits to the HOC logic to provide a reference lookup rather than using pixels to determine third-party status. In addition, I updated the documentation on seed files in the .yml as general cleanup.

Description

Please include a summary of the change, including any relevant background, motivation, and context.

If relevant, include a description, screenshots, etc. of new behavior/model/update/...

Links

Jira ticket(s): https://codedotorg.atlassian.net/jira/software/projects/DATAOPS/boards/72?selectedIssue=DATAOPS-1027

Testing story

  • Does your change include appropriate tests on key columns?
    eg.
    - not_null
    - unique
    - `dbt_utils.unique_combination_of_columns: , ["value","value","value"...]

Note: when submitting a new model for review please make sure the following have been tested:

  1. The model compiles (dbt build -m 'your_model')
    or: has the dbt Cloud job succeeded?
  2. The model runs (dbt run -m 'your_model')
  3. The model produces accessible data in the DW (select 1 from 'your_model')

Privacy

  • 1. Does this change involve the collection, use, or sharing of new Personal Data? No
  • 2. Do these data exist in the appropriate schema(s)? Yes
  • 3. Does this change involve a new or changed use or sharing of existing Personal Data? No
  • 4. Consider: will this data be visible on Tableau? will this data be surfaced in a report exported from Trevor? Need to update Tableau to reflect Hydrone data
  • 5. If yes to any of the above, please list the models, columns, and justification below:
    i.
    ii.
    iii.

PR Checklist:

--> Note: if these are not all checked, the PR will be sent back.

  • Tests provide adequate coverage
  • Privacy and Security impacts have been assessed
  • Code adheres to style guide👀 and is DRY
  • Code is well-commented (**please do not leave extraneous commentary in model code, if it is for the purpose of documentation, please relocate accordingly)
  • Appropriate documentation has been provided (see .yml., did dbt docs generate succeed?)
  • New features are translatable or updates will not break up/downstream models
  • Relevant documentation has been added or updated (i.e. dbt docs has been updated successfully on Github Pages
  • Pull Request is labeled appropriately (eg. chore/, feature/, fix/)
  • Follow-up work items (including potential tech debt) are tracked and linked (if applicable)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants