Handle auto layout with scaled widget #17822
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
hi, @thuydx55 What issue does this PR address? |
|
@zilongshanren I got problem while displaying scaled Widget in a Layout. They're placed in weird positions. This PR uses boundingBox instead of contentSize for calculating Widget position in layout |
|
@thuydx55 |
|
@zilongshanren I've added test for this issue (C++)
Before: After: |
|
Just added test for JS |
|
@zilongshanren All checks are passed |
zilongshanren
approved these changes
May 26, 2017
|
@thuydx55 |
|
@zilongshanren Pls take a look at cocos2d/cocos2d-html5#3488. Thanks |
stevetranby
added a commit
to stevetranby/cocos2d-x
that referenced
this pull request
Jun 16, 2017
* commit '639737286f594f3e06c07b22b352dddb01858883': before draw event (cocos2d#17669) Handle auto layout with scaled widget (cocos2d#17822) fix to problem with updating APK in Google Play keeping old OBB (cocos2d#17689) update console to fix compiling issue on with Xcode 8.3+ (cocos2d#17862) Fix iskindof (cocos2d#17785) [ci skip][AUTO]: updating luabinding & jsbinding & cocos_file.json automatically (cocos2d#17857) fix action running times for instant actions (cocos2d#17849) make fps stable on iOS (cocos2d#17852) [ci skip][AUTO]: updating luabinding & jsbinding & cocos_file.json automatically (cocos2d#17848) LayerRadialGradient works on mac and iOS (cocos2d#17826) Fixing serious XMLHTTP leak when CC_ENABLE_GC_FOR_NATIVE_OBJECTS enabled (cocos2d#17844) Call 'update' method in 'stop/stopAll' to cleanup immediately (cocos2d#17846) Add const keyword to Node::isScheduled (cocos2d#17841) small BillBoard optimizations (cocos2d#17825) Allow visit Sprite without camera for render to texture (cocos2d#17824) # Conflicts: # cocos/base/CCDirector.cpp # cocos/base/CCDirector.h # cocos/scripting/lua-bindings/auto/lua_cocos2dx_auto.hpp # cocos/ui/UILayoutManager.cpp # tools/cocos2d-console
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.