fix: 修复promise相关错误，issue参考https://forum.cocos.org/t/topic/158288/20 #4357
+148
−21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@minggo @dumganhar 想问下这个大概什么时候可以合入呀 |
|
@dumganhar 请 review 一下。 |
|
2.x 如果还要发版本的话，应该参考 3.x 的这个 PR 做修改： 这个 PR 解决了一些列的捕获 promise 的问题。 |
|
@minggo @dumganhar 那个promise的修复是官方来根据3.x改吗？ |
|
@nai6514531 |
|
@dumganhar 好的，期待发布，因为这个还蛮重要的。 |
|
@dumganhar 3.8的改动是参考d8吗？ |
@nai6514531 是的。 |
|
@dumganhar @minggo 我看新增了2.4.14的分支，可以把这个promise修复的加进去吗 |
|
可以的。 |
2.4.14的版本预计什么时候发布呀。 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.