requests: refactor SVSM request loop #613
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msft-jlange
force-pushed
the
req_task
branch
from
b5e4a1a to
dd9f0b1
Compare
joergroedel
reviewed
Feb 14, 2025
msft-jlange
force-pushed
the
req_task
branch
from
dd9f0b1 to
6b11b62
Compare
Invocation of `halt` is a platform-specific operation, so all uses of `halt` should invoke the platform-specific routine instead of a generic utility version. Signed-off-by: Jon Lange <[email protected]>
This change modifies the idle task flow so that all CPUs use the same idle loop, which is responsible for kicking off request processing on each CPU. Signed-off-by: Jon Lange <[email protected]>
The idle task should be reserved for cases where the vCPU goes completely idle. Request processing should be in a separate task. Moving the request loop to a separate task has the additional benefit of making it easier to move request processing to user mode in the future. Signed-off-by: Jon Lange <[email protected]>
The SVSM request loop is not meaningful on non-SNP platforms, so it should not be invoked on non-SNP platforms. Signed-off-by: Jon Lange <[email protected]>
msft-jlange
force-pushed
the
req_task
branch
from
6b11b62 to
d62f63d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move the SVSM request loop out of the idle task and into a separate task, and invoke it only on SNP platforms. This is a step towards moving SVSM request processing out of the kernel, and enabling it to be excluded in configurations that only support paravisor processing.