Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui-components: updated the icon-container class so that it vertically aligns the icon within its container #552

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ryanluu12345
Copy link
Contributor

@ryanluu12345 ryanluu12345 commented May 7, 2024

Previously, the icon was not centered with the text. With this change, it is now centered vertically.

Release Note: None

Before
image

After
image

📦 Published PR as canary version: Canary Versions

✨ Test out this PR locally via:

npm install @cockroachlabs/[email protected]
# or 
yarn add @cockroachlabs/[email protected]

… aligns the icon within its container

Previously, the icon was not centered with the text. With this change, it is now centered vertically.

Release Note: None
@ryanluu12345 ryanluu12345 requested a review from a team as a code owner May 7, 2024 17:14
Copy link
Collaborator

@laurenbarker laurenbarker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the huge lag here 😓 LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants