Skip to content

Add docs for CREATE TABLE ... AS OF SYSTEM TIME #19674

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 18, 2025
Merged

Add docs for CREATE TABLE ... AS OF SYSTEM TIME #19674

merged 1 commit into from
Jun 18, 2025

Conversation

rmloveland
Copy link
Contributor

Fixes DOC-13310

@rmloveland rmloveland marked this pull request as draft May 29, 2025 20:45
@netlify Netlify
Copy link

netlify bot commented May 29, 2025 •
edited
Loading

✅ Deploy Preview for cockroachdb-api-docs canceled.

Name Link
🔨 Latest commit eae0863
🔍 Latest deploy log https://app.netlify.com/projects/cockroachdb-api-docs/deploys/685314fc4ebd450008f38b59

@github-actions GitHub Actions
Copy link

github-actions bot commented May 29, 2025 •
edited
Loading

Files changed:

@netlify Netlify
Copy link

netlify bot commented May 29, 2025 •
edited
Loading

✅ Deploy Preview for cockroachdb-interactivetutorials-docs canceled.

Name Link
🔨 Latest commit eae0863
🔍 Latest deploy log https://app.netlify.com/projects/cockroachdb-interactivetutorials-docs/deploys/685314fcdebed500088579e7

@netlify Netlify
Copy link

netlify bot commented May 29, 2025 •
edited
Loading

✅ Netlify Preview

Name Link
🔨 Latest commit eae0863
🔍 Latest deploy log https://app.netlify.com/projects/cockroachdb-docs/deploys/685314fc2c44530008ad6aa4
😎 Deploy Preview https://deploy-preview-19674--cockroachdb-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@rmloveland rmloveland force-pushed the 20250529-DOC-13310-ctas-aost branch 4 times, most recently from 0c99b3d to a8f42f6 Compare June 4, 2025 19:03
@rmloveland rmloveland marked this pull request as ready for review June 4, 2025 19:12
@rmloveland rmloveland requested review from rafiss and dikshant June 4, 2025 19:13
rafiss
rafiss approved these changes Jun 9, 2025
View reviewed changes
Copy link
Contributor

@rafiss rafiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these changes lgtm!

i wasn't sure if @dikshant also wanted to have CREATE MATERIALIZED VIEW ... AS OF SYSTEM TIME documented. i'll leave that decision to him.

@dikshant
Copy link

dikshant commented Jun 9, 2025

Yeah we also want the materialized view part to be documented. But I'll leave it to Rich to decide if he wants to do that in this PR or a new one.

dikshant
dikshant approved these changes Jun 9, 2025
View reviewed changes
Copy link

@dikshant dikshant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM but One more example that I think we should add!

@rmloveland rmloveland requested a review from taroface June 9, 2025 20:04
@rmloveland
Copy link
Contributor Author

Yeah we also want the materialized view part to be documented. But I'll leave it to Rich to decide if he wants to do that in this PR or a new one.

I'll do it in another PR! would rather get this smaller one now in so folks can start using this ASAP

taroface
taroface reviewed Jun 10, 2025
View reviewed changes
Copy link
Contributor

@taroface taroface left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple suggestions...

@rmloveland
Copy link
Contributor Author

@taroface thanks for your feedback on this, in addition to the per-comment updates in 2a368ce, I went and updated the "undo accidental table deletion" example to be a bit more realistic by having the user drop movr.vehicle_location_histories and then recreate it, since (1) it's one of the bigger tables, so hopefully more interesting, (2) it allows us to drop the distraction of populating a tiny fake table in the example, and (3) everything else on the page uses movr so let's stick with it.

PTAL and let me know what you think!

@rmloveland rmloveland requested a review from taroface June 17, 2025 15:28
taroface
taroface approved these changes Jun 17, 2025
View reviewed changes
Copy link
Contributor

@taroface taroface left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, 1 follow-up comment

@rmloveland
Copy link
Contributor Author

Thanks for the reviews all! I am now going to port the changes in this PR to the v25.3 docs folder which was created after this PR was opened

@rmloveland
Add docs for CREATE TABLE ... AS OF SYSTEM TIME
eae0863 
Fixes DOC-13310

NB. These changes are applied to v25.2, v25.3
@rmloveland rmloveland force-pushed the 20250529-DOC-13310-ctas-aost branch from b731321 to eae0863 Compare June 18, 2025 19:35
@rmloveland rmloveland enabled auto-merge (squash) June 18, 2025 19:35
@rmloveland rmloveland merged commit 2a07c18 into main Jun 18, 2025
7 checks passed
@rmloveland rmloveland deleted the 20250529-DOC-13310-ctas-aost branch June 18, 2025 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rafiss rafiss rafiss approved these changes

@taroface taroface taroface approved these changes

@dikshant dikshant dikshant approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rmloveland @dikshant @rafiss @taroface