Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add zone config troubleshooting guide #19283

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

rmloveland
Copy link
Contributor

@rmloveland rmloveland commented Jan 6, 2025

Fixes DOC-9210

Summary of changes:

  • Add a new page, 'Troubleshoot Replication Zones', to The
    ZoneConfigonomicon (tm)

  • Update the 'Replication controls' page with more detailed info re:
    zone config inheritance hierarchy and behavior

  • Update the made-up examples in the 'Critical nodes endpoint' docs to
    point back to 'Troubleshoot Replication Zones'

  • Fix incorrect statements on the ALTER RANGE page since they're
    needed to map from range IDs returned by the critical nodes
    endpoint (mentioned in 'Troubleshoot Replication Zones') to actual
    schema objects

  • Add moar links (tm) from various zone config-related pages to the new
    troubleshooting guide and amongst themselves

  • Add a note to various zone config-related docs saying "most users
    should not do manual zone config changes, see Multi-region SQL and
    Zone Config Extensions instead"

For reviewers, the main changes are:

  • new Troubleshoot replication zones page
  • new section of 'Replication Controls' page called How zone config inheritance works
  • small changes to ALTER RANGE docs to update the SHOW RANGES queries to get them to actually work (they were missing the ... WITH DETAILS clause, and/or using crdb_internal.ranges - this was a bit of a driveby change but seemed good to do since I was touching ALTER RANGE ... CONFIGURE ZONE to point to the troubleshooting guide
  • most of the other changes are "infrastructure", adding links, etc.

@rmloveland rmloveland marked this pull request as draft January 6, 2025 22:39
@rmloveland rmloveland force-pushed the 20241209-DOC-9210-zone-config-troubleshooting-guide branch 7 times, most recently from e8df32a to 674915d Compare January 15, 2025 19:52
@rmloveland rmloveland force-pushed the 20241209-DOC-9210-zone-config-troubleshooting-guide branch 6 times, most recently from e11a980 to d460824 Compare January 27, 2025 21:57
@rmloveland rmloveland force-pushed the 20241209-DOC-9210-zone-config-troubleshooting-guide branch 3 times, most recently from fc2c697 to ab3faec Compare February 3, 2025 22:57
@rmloveland rmloveland force-pushed the 20241209-DOC-9210-zone-config-troubleshooting-guide branch from ab3faec to fb31a32 Compare February 4, 2025 17:03
@cockroachdb cockroachdb deleted a comment from netlify bot Feb 4, 2025
@cockroachdb cockroachdb deleted a comment from netlify bot Feb 4, 2025
@cockroachdb cockroachdb deleted a comment from netlify bot Feb 4, 2025
@rmloveland rmloveland marked this pull request as ready for review February 4, 2025 19:08
@cockroachdb cockroachdb deleted a comment from github-actions bot Feb 4, 2025
@rmloveland rmloveland force-pushed the 20241209-DOC-9210-zone-config-troubleshooting-guide branch 2 times, most recently from 0f0bfde to a2f820e Compare February 4, 2025 19:13
@cockroachdb cockroachdb deleted a comment from github-actions bot Feb 4, 2025
Copy link

github-actions bot commented Feb 4, 2025

Files changed:

Fixes DOC-9210

Summary of changes:

- Add a new page, 'Troubleshoot Replication Zones', to _The
  ZoneConfigonomicon (tm)_

- Update the 'Replication controls' page with more detailed info re:
  zone config inheritance hierarchy and behavior

- Update the made-up examples in the 'Critical nodes endpoint' docs to
  point back to 'Troubleshoot Replication Zones'

- Fix incorrect statements on the `ALTER RANGE` page since they're
  needed to map from range IDs returned by the critical nodes
  endpoint (mentioned in 'Troubleshoot Replication Zones') to actual
  schema objects

- Add moar links (tm) from various zone config-related pages to the new
  troubleshooting guide and amongst themselves

- Add a note to various zone config-related docs saying "most users
  should not do manual zone config changes, see Multi-region SQL and
  Zone Config Extensions instead"
@rmloveland rmloveland force-pushed the 20241209-DOC-9210-zone-config-troubleshooting-guide branch from a2f820e to a91c384 Compare February 4, 2025 20:13
@rmloveland rmloveland requested a review from fqazi February 4, 2025 21:58
@rmloveland rmloveland requested a review from annrpom February 4, 2025 21:58

The following example query uses the [`SHOW RANGES`]({% link {{ page.version.version }}/show-ranges.md %}) statement to show, for each range ID, which tables and indexes use that range for their underlying storage. The query assumes the [`movr` schema]({% link {{ page.version.version }}/movr.md %}#the-movr-database) that is loaded by [`cockroach demo`]({% link {{ page.version.version }}/cockroach-demo.md %}), so you'll need to modify it to work with your schema.

XXX: GET HELP WITH THIS QUERY, OUTPUT SEEMS NOT QUITE RIGHT??? (or is it ok?)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fqazi and @annrpom , i think this SQL query to map from range IDs to schema object names could be improved, it "kinda works" (tm) but please feel free to suggest improvements

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(as you can see the output is maybe not the best)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant