-
Notifications
You must be signed in to change notification settings - Fork 469
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOC-11414 PR #132257 - diagnostics: check license and diagnostics settings for cluster report #19008
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…h Trial or Free licenses.
Files changed: |
✅ Deploy Preview for cockroachdb-interactivetutorials-docs canceled.
|
✅ Deploy Preview for cockroachdb-api-docs canceled.
|
✅ Netlify Preview
To edit notification comments on pull requests, go to your Netlify site configuration. |
angles-n-daemons
approved these changes
Oct 14, 2024
kathancox
approved these changes
Oct 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two small comments, but otherwise LGTM, I'm not totally up on what we're doing terminology wise for the licenses.
rmloveland
added a commit
that referenced
this pull request
Nov 7, 2024
rmloveland
added a commit
that referenced
this pull request
Nov 18, 2024
* Backport changes from #19008 (#19106) Addresses DOC-11674 Summary of changes: - Backport changes from #19008 to v23.1, v23.2, v24.1, and v24.2 * Backport changes from #19072 (#19109) * Backport changes from #19072 Addresses DOC-11674 Summary of changes: - Backport #19072 to v23.1, v23.2, v24.1, v24.2 * Backport changes from #19031 (#19108) Addresses DOC-11674 Summary of changes: - Backport #19031 to v23.1, v23.2, v24.1, v24.2 * Backport changes from #19001 (#19103) Addresses DOC-10665, DOC-11674 Summary of changes: - Backport changes from #19001; a few manual edits were required due to a few patches that didn't merge automagically * Backport changes from #19126 (#19133) Addresses DOC-11674, DOC-11692 * Merge origin/main into 20241029-DOC-10624-backports (#19140) * Merge origin/main back into core relicensing backport branch (#19142) * Backport changes from #19002 (#19138) * Backport changes from #19002 Addresses DOC-11674 * Backport telemetry docs from #19131 (#19145) Addresses DOC-11051 * Backport upgrade license info from #19125 (#19146) Addresses DOC-11693 * Fix broken link on upgrade page include --------- Co-authored-by: Rich Loveland <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes DOC-11414
In diagnostics-reporting.md, added note to ignore cluster setting with Trial or Free licenses.
Rendered preview