-
Notifications
You must be signed in to change notification settings - Fork 456
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update cockroachcloud/ links to use Liquid syntax #18844
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for cockroachdb-interactivetutorials-docs canceled.
|
✅ Deploy Preview for cockroachdb-api-docs canceled.
|
✅ Netlify Preview
To edit notification comments on pull requests, go to your Netlify site configuration. |
mdlinville
approved these changes
Aug 21, 2024
mdlinville
added a commit
that referenced
this pull request
Aug 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses the part of DOC-10953 that can be accomplished 99.9% mechanically
Note: This does not touch
releases/
ormolt/
but those are much smaller. I suspectreleases/
will be a bit more complicated due to the whole versioning situation, so that will be easier to do in another targeted PR. It also does not touch any non-Liquid URLs which are being used inside HTML markup.All but a few of the edits in this PR were accomplished with the following one-liners, which were run separately in every version subdirectory (e.g.
v24.2
) and every include subdirectory (e.g._includes/v24.2
).The mechanical changes revealed 2 broken anchor links in
authorization.md
andmigration-overview.md
(identical across several versions) which needed 6-8 manual edits.One-liner for non-Liquid Markdown links without anchors:
One-liner for non-Liquid Markdown links with anchors: