Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DOC-10895 Cloud 2.0 update export logs and metrics for Azure Monitor #18841

Merged
merged 9 commits into from
Aug 23, 2024
Merged

DOC-10895 Cloud 2.0 update export logs and metrics for Azure Monitor #18841

merged 9 commits into from
Aug 23, 2024

Conversation

florence-crl
Copy link
Contributor

@florence-crl florence-crl commented Aug 20, 2024 •
edited
Loading

Fixes DOC-10895

  • In cockroachdb-feature-availability.md, (1) replaced dedicated with advanced, (2) updated links to export-*-advanced, (3) replaced AWS CloudWatch with Amazon CloudWatch.
  • In export-metrics.md, (1) removed mentions of Azure Monitor.
  • In export-metrics-advanced.md, (1) added mentions of Azure Monitor, (2) replaced mentions of dedicated with advanced, (3) added Prometheus preview note for Azure.
  • In export-logs.md, (1) removed mentions of Azure monitor, (2) added filter-tabs include for Standard/Advanced, (3) resolved merge conflict.
  • In export-logs-advanced.md, (1) added mentions of Azure monitor, (2) replaced AWS CloudWatch with Amazon CloudWatch, (3) corrected references to config step.
  • In export-*.md files, (1) replaced cockroachlabs.com links with liquid links, (2) replaced AWS CloudWatch with Amazon CloudWatch, (3) removed en-us from external links.

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 20, 2024 •
edited
Loading

Files changed:

@netlify Netlify
Copy link

netlify bot commented Aug 20, 2024

✅ Deploy Preview for cockroachdb-api-docs canceled.

Name Link
🔨 Latest commit 39e93e8
🔍 Latest deploy log https://app.netlify.com/sites/cockroachdb-api-docs/deploys/66c4dffeb168d10008fc8045

@netlify Netlify
Copy link

netlify bot commented Aug 20, 2024

✅ Deploy Preview for cockroachdb-interactivetutorials-docs canceled.

Name Link
🔨 Latest commit 39e93e8
🔍 Latest deploy log https://app.netlify.com/sites/cockroachdb-interactivetutorials-docs/deploys/66c4dffef637e400086bc2e1

@florence-crl florence-crl changed the base branch from main to cloud-2.0 August 20, 2024 18:27
@netlify Netlify
Copy link

netlify bot commented Aug 20, 2024 •
edited
Loading

✅ Netlify Preview

Name Link
🔨 Latest commit 60660a2
🔍 Latest deploy log https://app.netlify.com/sites/cockroachdb-docs/deploys/66c8cc99ad01400008841dcb
😎 Deploy Preview https://deploy-preview-18841--cockroachdb-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@florence-crl
In cockroachdb-feature-availability.md, (1) replaced dedicated with a…
da0545f 
…dvanced, (2) updated links to export-*-advanced.
@florence-crl
In export-metrics.md, (1) removed mentions of Azure Monitor.
6d46c29 
In export-metrics-advanced.md, (1) added mentions of Azure Monitor, (2) replaced mentions of dedicated with advanced.

In export-metrics.md and export-metrics-advanced.md, (1) replaced cockroachlabs.com links with liquid links, (2) removed en-us from external links, (3) removed hard coded links to export-metrics.
@florence-crl
In export-metrics.md and export-metrics-advanced.md, (1) added back h…
1cd11ca 
…ard coded links to export-metrics.
@florence-crl
In export-logs.md, (1) added filter-tabs include for Standard/Advance…
50a5cc3 
…d, (2) removed mentions of Azure monitor, (3) replaced AWS CloudWatch with Amazon CloudWatch, (4) resolved merge conflict, (5) replaced cockroachlabs.com links with liquid links.
@florence-crl
In export-logs-advanced.md, (1) added mentions of Azure monitor, (2) …
5ec2d1b 
…removed en-us from external links.

(3) replaced AWS CloudWatch with Amazon CloudWatch, (4) replaced cockroachlabs.com links with liquid links.
@florence-crl
In export-logs-advanced.md, (5) corrected references to config step.
5529857
@florence-crl
In cockroachdb-feature-availability.md, (3) replaced AWS CloudWatch w…
97e74f6 
…ith Amazon CloudWatch.
kathancox
kathancox approved these changes Aug 23, 2024
View reviewed changes
Copy link
Contributor

@kathancox kathancox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some suggestions, otherwise LGTM

src/current/cockroachcloud/export-logs-advanced.md Outdated Show resolved Hide resolved
src/current/cockroachcloud/export-logs-advanced.md Outdated Show resolved Hide resolved
src/current/cockroachcloud/export-logs-advanced.md Outdated Show resolved Hide resolved
src/current/cockroachcloud/export-logs-advanced.md Outdated Show resolved Hide resolved
src/current/cockroachcloud/export-logs-advanced.md Outdated Show resolved Hide resolved
src/current/cockroachcloud/export-logs-advanced.md Outdated Show resolved Hide resolved
src/current/cockroachcloud/export-logs-advanced.md Outdated Show resolved Hide resolved
src/current/cockroachcloud/export-metrics-advanced.md Outdated Show resolved Hide resolved
src/current/cockroachcloud/export-metrics-advanced.md Outdated Show resolved Hide resolved
src/current/cockroachcloud/export-metrics-advanced.md Outdated Show resolved Hide resolved
florence-crl
florence-crl commented Aug 23, 2024
View reviewed changes
Copy link
Contributor Author

@florence-crl florence-crl left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TFTR

src/current/cockroachcloud/export-logs-advanced.md Outdated Show resolved Hide resolved
src/current/cockroachcloud/export-logs-advanced.md Outdated Show resolved Hide resolved
src/current/cockroachcloud/export-logs-advanced.md Outdated Show resolved Hide resolved
src/current/cockroachcloud/export-logs-advanced.md Outdated Show resolved Hide resolved
src/current/cockroachcloud/export-logs-advanced.md Outdated Show resolved Hide resolved
src/current/cockroachcloud/export-logs-advanced.md Outdated Show resolved Hide resolved
src/current/cockroachcloud/export-logs-advanced.md Outdated Show resolved Hide resolved
src/current/cockroachcloud/export-metrics-advanced.md Outdated Show resolved Hide resolved
src/current/cockroachcloud/export-metrics-advanced.md Outdated Show resolved Hide resolved
src/current/cockroachcloud/export-metrics-advanced.md Outdated Show resolved Hide resolved
@florence-crl florence-crl merged commit 4d8a7d2 into cloud-2.0 Aug 23, 2024
4 checks passed
@florence-crl florence-crl deleted the DOC-10895 branch August 23, 2024 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kathancox kathancox kathancox approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@florence-crl @kathancox