Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TA 122372 #18837

Merged
merged 6 commits into from
Sep 3, 2024
Merged

Add TA 122372 #18837

merged 6 commits into from
Sep 3, 2024

Conversation

kathancox
Copy link
Contributor

Technical Advisory 122372

Copy link

netlify bot commented Aug 19, 2024

Deploy Preview for cockroachdb-interactivetutorials-docs canceled.

Name Link
🔨 Latest commit 6f544c8
🔍 Latest deploy log https://app.netlify.com/sites/cockroachdb-interactivetutorials-docs/deploys/66d76f79b89b06000975e9e0

Copy link

netlify bot commented Aug 19, 2024

Deploy Preview for cockroachdb-api-docs canceled.

Name Link
🔨 Latest commit 6f544c8
🔍 Latest deploy log https://app.netlify.com/sites/cockroachdb-api-docs/deploys/66d76f79a933930008b1baf4

Copy link

netlify bot commented Aug 19, 2024

Netlify Preview

Name Link
🔨 Latest commit 6f544c8
🔍 Latest deploy log https://app.netlify.com/sites/cockroachdb-docs/deploys/66d76f79a933930008b1baf0
😎 Deploy Preview https://deploy-preview-18837--cockroachdb-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@kathancox kathancox requested a review from rytaft August 20, 2024 19:38
@kathancox
Copy link
Contributor Author

kathancox commented Aug 20, 2024

@rytaft @rharding6373 I also added notes to the v23.2 and v24.1 docs by the Kafka sink section to recommend users enable the cluster setting. I haven't yet added a note to the v24.2 docs, it looks as though users would have to enable the setting manually for test releases and v24.2.0?

Copy link
Contributor

@rytaft rytaft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thank you!

@rytaft
Copy link
Contributor

rytaft commented Aug 22, 2024

I haven't yet added a note to the v24.2 docs, it looks as though users would have to enable the setting manually for test releases and v24.2.0?

That's correct

Copy link

@rharding6373 rharding6373 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Copy link
Contributor

@rmloveland rmloveland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as well

@rmloveland rmloveland marked this pull request as ready for review September 3, 2024 15:07
@rmloveland rmloveland merged commit 1eff7e1 into main Sep 3, 2024
6 checks passed
@rmloveland rmloveland deleted the ta-122372 branch September 3, 2024 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants