Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MOLT Fetch modes #18820

Merged
merged 4 commits into from
Aug 15, 2024
Merged

MOLT Fetch modes #18820

merged 4 commits into from
Aug 15, 2024

Conversation

taroface
Copy link
Contributor

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 14, 2024 •
edited
Loading

Files changed:

@netlify Netlify
Copy link

netlify bot commented Aug 14, 2024 •
edited
Loading

✅ Deploy Preview for cockroachdb-interactivetutorials-docs canceled.

Name Link
🔨 Latest commit ce14ca5
🔍 Latest deploy log https://app.netlify.com/sites/cockroachdb-interactivetutorials-docs/deploys/66be3bcb19efcb0008f43ac2

@netlify Netlify
Copy link

netlify bot commented Aug 14, 2024 •
edited
Loading

✅ Deploy Preview for cockroachdb-api-docs canceled.

Name Link
🔨 Latest commit ce14ca5
🔍 Latest deploy log https://app.netlify.com/sites/cockroachdb-api-docs/deploys/66be3bcbafa6590008246509

@netlify Netlify
Copy link

netlify bot commented Aug 14, 2024 •
edited
Loading

✅ Netlify Preview

Name Link
🔨 Latest commit ce14ca5
🔍 Latest deploy log https://app.netlify.com/sites/cockroachdb-docs/deploys/66be3bca17047800081162bf
😎 Deploy Preview https://deploy-preview-18820--cockroachdb-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

ryanluu12345
ryanluu12345 approved these changes Aug 15, 2024
View reviewed changes
Copy link

@ryanluu12345 ryanluu12345 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢 it

@kathancox kathancox self-requested a review August 15, 2024 16:44
kathancox
kathancox approved these changes Aug 15, 2024
View reviewed changes
Copy link
Contributor

@kathancox kathancox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, one very minor, non-blocking suggestion!

src/current/molt/molt-fetch.md Show resolved Hide resolved
src/current/molt/molt-fetch.md Show resolved Hide resolved
@taroface taroface enabled auto-merge (squash) August 15, 2024 17:23
@taroface taroface merged commit 9845879 into main Aug 15, 2024
6 checks passed
@taroface taroface deleted the molt-fetch-modes branch August 15, 2024 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jeremyyang920 Jeremyyang920 Jeremyyang920 approved these changes

@ryanluu12345 ryanluu12345 ryanluu12345 approved these changes

@kathancox kathancox kathancox approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@taroface @Jeremyyang920 @ryanluu12345 @kathancox