Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DOC-10237] IdP-initiated SAML flow enabled by default #18646

Merged
merged 12 commits into from
Jun 17, 2024
Merged

[DOC-10237] IdP-initiated SAML flow enabled by default #18646

merged 12 commits into from
Jun 17, 2024

Conversation

mdlinville
Copy link
Contributor

@mdlinville mdlinville commented Jun 12, 2024 •
edited
Loading

[DOC-10237] IdP-initiated SAML flow enabled by default

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 12, 2024 •
edited
Loading

Files changed:

@netlify Netlify
Copy link

netlify bot commented Jun 12, 2024 •
edited
Loading

✅ Deploy Preview for cockroachdb-interactivetutorials-docs canceled.

Name Link
🔨 Latest commit 937e21a
🔍 Latest deploy log https://app.netlify.com/sites/cockroachdb-interactivetutorials-docs/deploys/66707917948d3900086f0890

@netlify Netlify
Copy link

netlify bot commented Jun 12, 2024 •
edited
Loading

✅ Deploy Preview for cockroachdb-api-docs canceled.

Name Link
🔨 Latest commit 937e21a
🔍 Latest deploy log https://app.netlify.com/sites/cockroachdb-api-docs/deploys/6670791704065500081774d6

@netlify Netlify
Copy link

netlify bot commented Jun 12, 2024 •
edited
Loading

✅ Netlify Preview

Name Link
🔨 Latest commit 937e21a
🔍 Latest deploy log https://app.netlify.com/sites/cockroachdb-docs/deploys/667079171c32090008804afe
😎 Deploy Preview https://deploy-preview-18646--cockroachdb-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@mdlinville mdlinville force-pushed the DOC-10237 branch 2 times, most recently from 4085163 to 3dd9763 Compare June 13, 2024 23:32
jaiayu
jaiayu approved these changes Jun 14, 2024
View reviewed changes
Copy link

@jaiayu jaiayu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks!

florence-crl
florence-crl approved these changes Jun 14, 2024
View reviewed changes
Copy link
Contributor

@florence-crl florence-crl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM pending suggestions (nits)

src/current/cockroachcloud/cloud-org-sso.md Outdated Show resolved Hide resolved
src/current/cockroachcloud/configure-cloud-org-sso.md Outdated Show resolved Hide resolved
@mdlinville mdlinville enabled auto-merge (squash) June 17, 2024 17:59
@mdlinville mdlinville merged commit 038a53a into main Jun 17, 2024
6 of 7 checks passed
@mdlinville mdlinville deleted the DOC-10237 branch June 17, 2024 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@florence-crl florence-crl florence-crl approved these changes

@jaiayu jaiayu jaiayu approved these changes

@linhcrl linhcrl Awaiting requested review from linhcrl

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mdlinville @florence-crl @jaiayu