Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DO NOT MERGE] Test support warning (re. assistance-only support and EOL) future states #18615

Draft
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

mikeCRL
Copy link
Contributor

@mikeCRL mikeCRL commented Jun 3, 2024

A test, following on #18611

Copy link

github-actions bot commented Jun 3, 2024

Files changed:

  • src/current/_includes/sidebar-data-v23.1.json
  • src/current/_includes/unsupported-version.md
  • src/current/_includes/v23.1/sidebar-data/latest-releases.json
  • src/current/_layouts/page.html

Copy link

netlify bot commented Jun 3, 2024

Deploy Preview for cockroachdb-api-docs canceled.

Name Link
🔨 Latest commit ea7205a
🔍 Latest deploy log https://app.netlify.com/sites/cockroachdb-api-docs/deploys/66677ba8d51d1b0008c0da06

Copy link

netlify bot commented Jun 3, 2024

Deploy Preview for cockroachdb-interactivetutorials-docs canceled.

Name Link
🔨 Latest commit ea7205a
🔍 Latest deploy log https://app.netlify.com/sites/cockroachdb-interactivetutorials-docs/deploys/66677ba8b2db0500094420c8

Copy link

netlify bot commented Jun 3, 2024

Netlify Preview

Name Link
🔨 Latest commit ea7205a
🔍 Latest deploy log https://app.netlify.com/sites/cockroachdb-docs/deploys/66677ba863a7490008b1adf2
😎 Deploy Preview https://deploy-preview-18615--cockroachdb-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@mikeCRL
Copy link
Contributor Author

mikeCRL commented Jun 4, 2024

@mdlinville When I manually set today to 2025-11-14, the warnings on these pages look good:

But shouldn't a warning also appear at the top of every doc page in 23.1 and 23.2? Nothing's showing up here:

Am I missing something, or is there a bug?

Note: The reason I continued to set a variable actual_today was to troubleshoot an earlier issue with my code; the idea was to add something like

Actually today: {{ actual_today }}
Future: {{ today }}

to validate the assignment of each. But I didn't need to do that, because the latest today code here seems to be working now.

@mdlinville
Copy link
Contributor

@mdlinville When I manually set today to 2025-11-14, the warnings on these pages look good:

But shouldn't a warning also appear at the top of every doc page in 23.1 and 23.2? Nothing's showing up here:

Am I missing something, or is there a bug?

Note: The reason I continued to set a variable actual_today was to troubleshoot an earlier issue with my code; the idea was to add something like

Actually today: {{ actual_today }}
Future: {{ today }}

to validate the assignment of each. But I didn't need to do that, because the latest today code here seems to be working now.

Can you rerun the test and instead of changing today, change the dates in versions.csv such that a given version looks to be EOL, or LTS maintenance, or whatever?

@mdlinville
Copy link
Contributor

I think this is ready to test again. When we are satisfied, we should decouple the logic changes and put them in another PR.

mdlinville added a commit that referenced this pull request Jun 18, 2024
* [DOC-10557] Fix LTS date logic bug and 23.1 TOC

- Also add debug capability (disabled by default)
- Also propagate the combined Releases TOC entry to 23.1
- Updates on top of the fix in #18615 to fix a regression
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants