Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add preview apache pulsar sink changefeed docs v24.1 #18529

Merged
merged 4 commits into from
Jun 10, 2024
Merged

Conversation

kathancox
Copy link
Contributor

@kathancox kathancox commented May 9, 2024

Fixes DOC-9664

This PR adds docs for the Apache Pulsar preview sink for v24.1.

  • Changefeed sink description
  • Short-form example
  • List of unsupported options/features
  • Added to the preview section of the CockroachDB Feature Availability page.

Follow the links in the Files changed box below for rendered previews.

Copy link

netlify bot commented May 9, 2024

Deploy Preview for cockroachdb-api-docs canceled.

Name Link
🔨 Latest commit 562585b
🔍 Latest deploy log https://app.netlify.com/sites/cockroachdb-api-docs/deploys/666761f05822cb000807a05f

Copy link

netlify bot commented May 9, 2024

Deploy Preview for cockroachdb-interactivetutorials-docs canceled.

Name Link
🔨 Latest commit 562585b
🔍 Latest deploy log https://app.netlify.com/sites/cockroachdb-interactivetutorials-docs/deploys/666761f0e868c200088514d2

Copy link

netlify bot commented May 9, 2024

Netlify Preview

Name Link
🔨 Latest commit 562585b
🔍 Latest deploy log https://app.netlify.com/sites/cockroachdb-docs/deploys/666761f09a2ce00008917c69
😎 Deploy Preview https://deploy-preview-18529--cockroachdb-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@@ -0,0 +1,11 @@
Changefeeds emitting to an Apache Pulsar sink do **not** support:

- [`resolved`]({% link {{ page.version.version }}/create-changefeed.md %}#resolved-option)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have included all these options as unsupported, but I was able to start changefeeds with at least the top three into pulsar and receive messages with the respective timestamps (e.g., resolved). Given Jay's issue, not sure if we want to include these or not. Maybe include until further testing?

Copy link

@rharding6373 rharding6373 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for putting this together! Only have one comment.

@kathancox
Copy link
Contributor Author

Thank you for putting this together! Only have one comment.

Hey @rharding6373, tftr, I don't see your comment in the PR.

Copy link
Contributor

@Amruta-Ranade Amruta-Ranade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kathancox kathancox merged commit f807529 into main Jun 10, 2024
6 checks passed
@kathancox kathancox deleted the apache-pulsar-sink branch June 10, 2024 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants