blobfixture: tolerate non-found errors #141839
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffswenson
requested review from
golgeek,
DarrylWong and
dt
and removed request for
a team
|
This PR depends on #141795. |
|
This change is |
⚪ Sysbench [SQL, 3node, oltp_read_write]
Reproducebenchdiff binaries: mkdir -p benchdiff/58b84a0/bin/1058449141
gcloud storage cp gs://cockroach-microbench-ci/builds/58b84a00047de54ce365afbf071778b456844ebc/bin/pkg_sql_tests benchdiff/58b84a0/bin/1058449141/cockroachdb_cockroach_pkg_sql_tests
chmod +x benchdiff/58b84a0/bin/1058449141/cockroachdb_cockroach_pkg_sql_tests
mkdir -p benchdiff/61ad6b7/bin/1058449141
gcloud storage cp gs://cockroach-microbench-ci/builds/61ad6b723ee22d647e5eeb3e47e3fb69be93785e/bin/pkg_sql_tests benchdiff/61ad6b7/bin/1058449141/cockroachdb_cockroach_pkg_sql_tests
chmod +x benchdiff/61ad6b7/bin/1058449141/cockroachdb_cockroach_pkg_sql_testsbenchdiff command: benchdiff --run=^BenchmarkSysbench/SQL/3node/oltp_read_write$ --old=61ad6b7 --new=58b84a0 ./pkg/sql/tests⚪ Sysbench [KV, 1node, local, oltp_read_only]
Reproducebenchdiff binaries: mkdir -p benchdiff/58b84a0/bin/1058449141
gcloud storage cp gs://cockroach-microbench-ci/builds/58b84a00047de54ce365afbf071778b456844ebc/bin/pkg_sql_tests benchdiff/58b84a0/bin/1058449141/cockroachdb_cockroach_pkg_sql_tests
chmod +x benchdiff/58b84a0/bin/1058449141/cockroachdb_cockroach_pkg_sql_tests
mkdir -p benchdiff/61ad6b7/bin/1058449141
gcloud storage cp gs://cockroach-microbench-ci/builds/61ad6b723ee22d647e5eeb3e47e3fb69be93785e/bin/pkg_sql_tests benchdiff/61ad6b7/bin/1058449141/cockroachdb_cockroach_pkg_sql_tests
chmod +x benchdiff/61ad6b7/bin/1058449141/cockroachdb_cockroach_pkg_sql_testsbenchdiff command: benchdiff --run=^BenchmarkSysbench/KV/1node_local/oltp_read_only$ --old=61ad6b7 --new=58b84a0 ./pkg/sql/tests⚪ Sysbench [KV, 1node, local, oltp_write_only]
Reproducebenchdiff binaries: mkdir -p benchdiff/58b84a0/bin/1058449141
gcloud storage cp gs://cockroach-microbench-ci/builds/58b84a00047de54ce365afbf071778b456844ebc/bin/pkg_sql_tests benchdiff/58b84a0/bin/1058449141/cockroachdb_cockroach_pkg_sql_tests
chmod +x benchdiff/58b84a0/bin/1058449141/cockroachdb_cockroach_pkg_sql_tests
mkdir -p benchdiff/61ad6b7/bin/1058449141
gcloud storage cp gs://cockroach-microbench-ci/builds/61ad6b723ee22d647e5eeb3e47e3fb69be93785e/bin/pkg_sql_tests benchdiff/61ad6b7/bin/1058449141/cockroachdb_cockroach_pkg_sql_tests
chmod +x benchdiff/61ad6b7/bin/1058449141/cockroachdb_cockroach_pkg_sql_testsbenchdiff command: benchdiff --run=^BenchmarkSysbench/KV/1node_local/oltp_write_only$ --old=61ad6b7 --new=58b84a0 ./pkg/sql/testsArtifactsdownload: mkdir -p new
gcloud storage cp gs://cockroach-microbench-ci/artifacts/58b84a00047de54ce365afbf071778b456844ebc/13459556616-1/\* new/
mkdir -p old
gcloud storage cp gs://cockroach-microbench-ci/artifacts/61ad6b723ee22d647e5eeb3e47e3fb69be93785e/13459556616-1/\* old/Legend
No regressions detected! built with commit: 58b84a00047de54ce365afbf071778b456844ebc |
jeffswenson
force-pushed
the
jeffswenson-improve-registry-gc
branch
from
58b84a0 to
cd5ef35
Compare
Previously, the external storage providers had different behavior when deleting an object that does not exist. S3 treats deleting a non-existent file as OK. All other storage providers returned an error. This change updates all storage providers so they match the S3 behavior. An alternative design would be to have Delete return ErrFileNotFound. I was unable to find an efficient way to implement that in the S3 storage provider. The S3 delete response provides no hint as to whether there was an object at the path. So generating ErrFileNotFound would require reading the path before issuing the delete. Release note: none Epic: none
Previously, when the fixture GC was running, registry operations could fail because they would list metadata blobs then attempt to read them. Now, the registry tolerates missing blobs with the assumption they were deleted by a concurrent GC. Release note: none Part of: cockroachdb#139159
jeffswenson
force-pushed
the
jeffswenson-improve-registry-gc
branch
from
cd5ef35 to
c97ba77
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, when the fixture GC was running, registry operations could
fail because they would list metadata blobs then attempt to read them.
Now, the registry tolerates missing blobs with the assumption they were
deleted by a concurrent GC.
Release note: none
Part of: #139159