roachtest: use artifacts/cockroach if possible #141367
Merged
+5
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This prepends PWD/artifacts to the paths searched for roachtest's required binaries, as this is where a binary built by dev cross, for use in a roachtest, is placed by default. Additionally, if the binary in found before searching paths, i.e. the one directly in PWD, fails the arch check, we now fall through to the searching and validation step rather than failing immediately; having an invalid-arch binary in PWD is common and expected for CRL engineers working on Darwin/arm, so we should not be surprised to see it and instead just move on to search for a valid one. Release note: none. Epic: none.
dt
changed the title
|
This change is |
|
Sanity check since we don't have good test coverage for finding the right binary... Feel free to bors after the sanity check. |
srosenberg
approved these changes
Feb 13, 2025
|
Thanks, sanity check seems to have succeeded with two tests failing due to vm preemptions. TFTR! bors r+ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This prepends PWD/artifacts to the paths searched for roachtest's required binaries, as this is where a binary built by dev cross, for use in a roachtest, is placed by default.
Additionally, if the binary in found before searching paths, i.e. the one directly in PWD, fails the arch check, we now fall through to the searching and validation step rather than failing immediately; having an invalid-arch binary in PWD is common and expected for CRL engineers working on Darwin/arm, so we should not be surprised to see it and instead just move on to search for a valid one.
Release note: none.
Epic: none.