testutils: move sideeye helper to its own package
#141182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
asg0451
approved these changes
Feb 11, 2025
rickystewart
force-pushed
the
move-side-eye
branch
from
0d16a20 to
c993225
Compare
|
bors r=asg0451 |
craig bot
pushed a commit
that referenced
this pull request
Feb 11, 2025
140525: changefeedccl: support envelope=enriched for avro r=aerfrei a=asg0451 Add support for the enriched envelope type to avro. Fixes: #139657 Release note (enterprise change): Add support for the enriched envelope type to avro. 140992: changefeedccl: add enriched_properties option r=aerfrei a=asg0451 (see individual commits) - Add the `enriched_properties` option which will control which properties are included in the enriched envelope. - The enriched envelope in json should not include the `payload` wrapper unless the schema is included. Fixes: #139687 Release note: None 141040: docs: update diagrams.go for removed restore syntax r=msbutler a=kev-cao The old restore syntax was removed in #135135 and with it, the `list_of_string_or_placeholder` was removed. `diagrams.go`'s entry for `restore_stmt` was not updated accordingly, resulting in a bad match in the `.bnf` files. Epic: none Release note: None 141151: sql: remove error log r=xinhaoz a=xinhaoz Missed this error log when consolidating some sql stats recording. Epic: none Release note: None 141182: testutils: move `sideeye` helper to its own package r=asg0451 a=rickystewart This being directly present in `pkg/testutils` meant that `side-eye` is directly linked into `cockroach`, which was not intentional. It also made `cockroach` impossible to build for `s390x` as `side-eye` doesn't support it. Since the helper is unused, we can just move the helper to its own package. Epic: CRDB-21133 Release note: None Co-authored-by: Miles Frankel <[email protected]> Co-authored-by: Kevin Cao <[email protected]> Co-authored-by: Xin Hao Zhang <[email protected]> Co-authored-by: Ricky Stewart <[email protected]>
srosenberg
approved these changes
Feb 11, 2025
|
Build failed (retrying...): |
craig bot
pushed a commit
that referenced
this pull request
Feb 11, 2025
140525: changefeedccl: support envelope=enriched for avro r=aerfrei a=asg0451 Add support for the enriched envelope type to avro. Fixes: #139657 Release note (enterprise change): Add support for the enriched envelope type to avro. 141040: docs: update diagrams.go for removed restore syntax r=msbutler a=kev-cao The old restore syntax was removed in #135135 and with it, the `list_of_string_or_placeholder` was removed. `diagrams.go`'s entry for `restore_stmt` was not updated accordingly, resulting in a bad match in the `.bnf` files. Epic: none Release note: None 141182: testutils: move `sideeye` helper to its own package r=asg0451 a=rickystewart This being directly present in `pkg/testutils` meant that `side-eye` is directly linked into `cockroach`, which was not intentional. It also made `cockroach` impossible to build for `s390x` as `side-eye` doesn't support it. Since the helper is unused, we can just move the helper to its own package. Epic: CRDB-21133 Release note: None Co-authored-by: Miles Frankel <[email protected]> Co-authored-by: Kevin Cao <[email protected]> Co-authored-by: Ricky Stewart <[email protected]>
|
bors r- |
|
Canceled. |
rickystewart
force-pushed
the
move-side-eye
branch
from
c993225 to
1b5b9f6
Compare
This being directly present in `pkg/testutils` meant that `side-eye` is directly linked into `cockroach`, which was not intentional. It also made `cockroach` impossible to build for `s390x` as `side-eye` doesn't support it. Since the helper is unused, we can just move the helper to its own package. Epic: CRDB-21133 Release note: None
rickystewart
force-pushed
the
move-side-eye
branch
from
1b5b9f6 to
b92432b
Compare
|
bors r=asg0451,srosenberg |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This being directly present in
pkg/testutilsmeant thatside-eyeis directly linked intocockroach, which was not intentional. It also madecockroachimpossible to build fors390xasside-eyedoesn't support it. Since the helper is unused, we can just move the helper to its own package.Epic: CRDB-21133
Release note: None