ci/roachtest: fix typo in roachtest nightly wrapper #140675
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previous PR [1] had a typo which caused RC runs to fail due to using an invalid CLI arg. [1] cockroachdb#137653 Epic: none Release note: None
srosenberg
requested review from
a team,
herkolategan and
golgeek
and removed request for
a team
|
This change is |
srosenberg
added
backport-25.1.0-rc
|
TFTR! |
|
bors r=darrylwong |
craig bot
pushed a commit
that referenced
this pull request
Feb 7, 2025
140409: metric: remove mutex around windowed histogram update r=dhartunian a=dhartunian Previously, we used an `RWMutex` to serialize access to the windowed histogram. This was done because there's a rotation that needs to happen that moves the currently active histogram into the `prev` variable and creates a fresh one to update in `cur`. This is done to maintain the window. This change limits the mutex usage to rotation and window snapshotting, removing the need to take a read lock during updates since we can atomically grab the `cur` histogram. There's a bit of nuance to manage around the fact that `prev` can be nil on the first iteration, since `cur` is the first histogram. After a single rotation, `prev` will not be nil again. The prometheus histogram itself (what's stored in the `atomic.Value`) is thread-safe. ``` old: dhartunian@507c68f Merge #140092 new: dhartunian@ff9dd52 metric: remove mutex around windowed histogram upd args: benchdiff "./pkg/util/metric" "-b" "-r" "BenchmarkHistogramRecordValue" "-c" "10" "--preview" name old time/op new time/op delta HistogramRecordValue/insert_zero-10 30.7ns ± 8% 24.3ns ± 2% -20.94% (p=0.000 n=9+8) HistogramRecordValue/insert_integers-10 37.4ns ± 6% 33.8ns ± 1% -9.83% (p=0.000 n=8+8) HistogramRecordValue/random_integers-10 44.9ns ± 9% 41.7ns ± 1% -7.25% (p=0.000 n=8+8) name old alloc/op new alloc/op delta HistogramRecordValue/insert_integers-10 0.00B 0.00B ~ (all equal) HistogramRecordValue/insert_zero-10 0.00B 0.00B ~ (all equal) HistogramRecordValue/random_integers-10 0.00B 0.00B ~ (all equal) name old allocs/op new allocs/op delta HistogramRecordValue/insert_integers-10 0.00 0.00 ~ (all equal) HistogramRecordValue/insert_zero-10 0.00 0.00 ~ (all equal) HistogramRecordValue/random_integers-10 0.00 0.00 ~ (all equal) ``` Part of #133306 Release note: None 140675: ci/roachtest: fix typo in roachtest nightly wrapper r=darrylwong a=srosenberg Previous PR [1] had a typo which caused RC runs to fail due to using an invalid CLI arg. [1] #137653 Epic: none Release note: None Release Justification: ci-only change Co-authored-by: David Hartunian <[email protected]> Co-authored-by: Stan Rosenberg <[email protected]>
|
Build failed (retrying...): |
This was referenced Feb 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous PR [1] had a typo which caused
RC runs to fail due to using an
invalid CLI arg.
[1] #137653
Epic: none
Release note: None
Release Justification: ci-only change