release-24.3: roachtest/mixedversion: WaitForReplication
must ensure SQL is ready
#140665
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 1/1 commits from #138109.
/cc @cockroachdb/release
Previously, mixedversion roachtests would occassionally fail while trying to execute SQL against a freshly started node; specifically,
get-user-session
would time out. The precise root cause is described in [1].As of [2],
WaitForReplication
is the default used by all mixedversion roachtests. Thus, it sufficesto ensure that "SQL is ready" before
WaitForReplication
is invoked.However, a number of roachtests don't opt into
StartOpts.WaitForReplication
, which makes themsusceptible to the same failure mode, e.g., [3].
Thus, we unconditionally
WaitForSQLReady
, forthe system tenant, on every started DB node.
[1] #137988
[2] #136607
[3] #137382
Fixes: #137988
Informs: #137332
Epic: none
Release note: None
Release Justification: test-only change