Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-24.3: roachtest/mixedversion: WaitForReplication must ensure SQL is ready #140665

Merged

Conversation

srosenberg
Copy link
Member

@srosenberg srosenberg commented Feb 7, 2025

Backport 1/1 commits from #138109.

/cc @cockroachdb/release


Previously, mixedversion roachtests would occassionally fail while trying to execute SQL against a freshly started node; specifically, get-user-session would time out. The precise root cause is described in [1].

As of [2], WaitForReplication is the default used by all mixedversion roachtests. Thus, it suffices
to ensure that "SQL is ready" before
WaitForReplication is invoked.

However, a number of roachtests don't opt into
StartOpts.WaitForReplication, which makes them
susceptible to the same failure mode, e.g., [3].
Thus, we unconditionally WaitForSQLReady, for
the system tenant, on every started DB node.

[1] #137988
[2] #136607
[3] #137382

Fixes: #137988
Informs: #137332

Epic: none
Release note: None
Release Justification: test-only change

Previously, mixedversion roachtests would occassionally
fail while trying to execute SQL against a freshly
started node; specifically, `get-user-session` would
time out. The precise root cause is described in [1].

As of [2], `WaitForReplication` is the default used
by all mixedversion roachtests. Thus, it suffices
to ensure that "SQL is ready" before
`WaitForReplication` is invoked.

However, a number of roachtests don't opt into
`StartOpts.WaitForReplication`, which makes them
susceptible to the same failure mode, e.g., [3].
Thus, we unconditionally `WaitForSQLReady`, for
the system tenant, on every started DB node.

[1] cockroachdb#137988
[2] cockroachdb#136607
[3] cockroachdb#137382

Fixes: cockroachdb#137988
Informs: cockroachdb#137332

Epic: none
Release note: None
@srosenberg srosenberg requested a review from a team as a code owner February 7, 2025 05:05
@srosenberg srosenberg requested review from golgeek and DarrylWong and removed request for a team February 7, 2025 05:05
Copy link

blathers-crl bot commented Feb 7, 2025

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Backports should only be created for serious
    issues
    or test-only changes.
  • Backports should not break backwards-compatibility.
  • Backports should change as little code as possible.
  • Backports should not change on-disk formats or node communication protocols.
  • Backports should not add new functionality (except as defined
    here).
  • Backports must not add, edit, or otherwise modify cluster versions; or add version gates.
  • All backports must be reviewed by the owning areas TL. For more information as to how that review should be conducted, please consult the backport
    policy
    .
If your backport adds new functionality, please ensure that the following additional criteria are satisfied:
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters. State changes must be further protected such that nodes running old binaries will not be negatively impacted by the new state (with a mixed version test added).
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.
  • Your backport must be accompanied by a post to the appropriate Slack
    channel (#db-backports-point-releases or #db-backports-XX-X-release) for awareness and discussion.

Also, please add a brief release justification to the body of your PR to justify this
backport.

@blathers-crl blathers-crl bot added the backport Label PR's that are backports to older release branches label Feb 7, 2025
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@srosenberg
Copy link
Member Author

TFTR!

@srosenberg srosenberg merged commit aa6be9e into cockroachdb:release-24.3 Feb 7, 2025
20 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Label PR's that are backports to older release branches
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants