schemachanger: remove RBR fallback for add column #140617
Open
+1,978
−397
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
annrpom
force-pushed
the
add-column-rbr
branch
from
cb71517 to
9a6b955
Compare
![blathers[crl]](https://avatars.githubusercontent.com/in/59700?s=40&u=373d9101a12edc3847d2fb6ae78e3adcfb4ca41e&v=4){kind=avatar}
|
It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR? 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
annrpom
force-pushed
the
add-column-rbr
branch
2 times, most recently
from
6731fed to
f288f4b
Compare
Some precursor work to remove RBR fallbacks for ADD COLUMN. Epic: CRDB-31282 Informs: cockroachdb#80545 Release note: None
Some precursor work to remove RBR fallbacks for ADD COLUMN. Epic: CRDB-31282 Informs: cockroachdb#80545 Release note: None
annrpom
force-pushed
the
add-column-rbr
branch
from
f288f4b to
5f1e89e
Compare
|
Your pull request contains more than 1000 changes. It is strongly encouraged to split big PRs into smaller chunks. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
annrpom
force-pushed
the
add-column-rbr
branch
2 times, most recently
from
4d2e3b6 to
afe63bb
Compare
This patch removes the regional by row fallback for `ADD COLUMN` in the declarative schema changer. Epic: CRDB-31282 Fixes: cockroachdb#80545 Release note: None
annrpom
force-pushed
the
add-column-rbr
branch
from
afe63bb to
da29679
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is stacked on top of another one!
Please consider reviewing that PR first. This message will be removed once the prerequisite PR is merged and this one is rebased.
This patch removes the regional by row fallback for
ADD COLUMNin the declarative schema changer.
Epic: CRDB-31282
Fixes: #80545
Release note: None