roachtest: use atomic pointer for logger #140604
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
DarrylWong
commented
Feb 6, 2025
DarrylWong
force-pushed
the
atomic-logger
branch
from
64d4eee to
dde0377
Compare
DarrylWong
requested review from
herkolategan and
golgeek
and removed request for
a team
The test runner swaps out the test logger when running post test artifacts collection and checks. However, in the case of a timeout, the test goroutine may still be running and have access to the test logger. This leads to a race condition where the logger is replaced as it's being used by the test. This change switches the test logger to use an atomic pointer instead.
DarrylWong
force-pushed
the
atomic-logger
branch
from
dde0377 to
3ca9845
Compare
srosenberg
approved these changes
Feb 6, 2025
herkolategan
approved these changes
Feb 7, 2025
|
TFTRs! bors=srosenberg,herkolategan |
|
Oops forgot the r 😛 bors r=srosenberg,herkolategan |
craig bot
pushed a commit
that referenced
this pull request
Feb 11, 2025
138834: kvserver,storeliveness: introduce follower quiescence r=arulajmani,iskettaneh a=miraradeva This commit introduces the ability for followers on inactive ranges to quiesce and stop ticking in Raft. This will allow the CPU utilization of the cluster to decrease by a factor of 2/3 (assuming RF3). Unlike epoch lease quiescence, which also quiesces the leader under certain conditions, store liveness quiescence is much simpler. The conditions to quiesce/unquiesce are: - Quiesce a follower if it hasn't received Raft messages in a certain number of ticks and the follower's store provides store liveness support for the leader's store. - Unquiesce a follower if it hears from store liveness that the follower's store has withdrawn support from the leader's store. Fixes: #133885 Release note: None 140604: roachtest: use atomic pointer for logger r=srosenberg,herkolategan a=DarrylWong The test runner swaps out the test logger when running post test artifacts collection and checks. However, in the case of a timeout, the test goroutine may still be running and have access to the test logger. This leads to a race condition where the logger is replaced as it's being used by the test. This change switches the test logger to use an atomic pointer instead. Fixes: none Epic: none Release note: none 140960: sql: deflake TestDropDatabaseDeleteData r=iskettaneh a=iskettaneh This commit deflakes the test by blocking the full reconciliation from starting before we drop the database. This is used to avoid a race condition where the full reconciliation starts after we drop the database, it will ignore the dropped database. Then, there is a race between the SQLWatcher and the GC job where the SQLWatcher might write a zone config of table1 before table2, while the GC queue might not know that this range needs to be split because it has different span config. Release note: None Fixes: #138185 141040: docs: update diagrams.go for removed restore syntax r=msbutler a=kev-cao The old restore syntax was removed in #135135 and with it, the `list_of_string_or_placeholder` was removed. `diagrams.go`'s entry for `restore_stmt` was not updated accordingly, resulting in a bad match in the `.bnf` files. Epic: none Release note: None Co-authored-by: Mira Radeva <[email protected]> Co-authored-by: DarrylWong <[email protected]> Co-authored-by: Ibrahim Kettaneh <[email protected]> Co-authored-by: Kevin Cao <[email protected]>
|
Build failed (retrying...):
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test runner swaps out the test logger when running post test artifacts collection and checks. However, in the case of a timeout, the test goroutine may still be running and have access to the test logger. This leads to a race condition where the logger is replaced as it's being used by the test.
This change switches the test logger to use an atomic pointer instead.
Fixes: none
Epic: none
Release note: none